This revision was automatically updated to reflect the committed changes.
Closed by commit rG64366d4935d3: [clangd] Rollforward include-cleaner library
usage in symbol collector. (authored by VitaNuo).
Changed prior to commit:
https://reviews.llvm.org/D156659?vs=556135&id=556396#toc
Repository
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156659/new/
https://reviews.llvm.org/D156659
VitaNuo updated this revision to Diff 556135.
VitaNuo marked an inline comment as done.
VitaNuo added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156659/new/
https://reviews.llvm.org/D156659
Files:
clang-tools-extr
VitaNuo marked 2 inline comments as done.
VitaNuo added inline comments.
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:919
+ if (IncludeHeader.empty())
+HeaderFileURIs->getIncludeHeader(FID);
+
kadircet wrote:
> i guess LHS of the as
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:828
- tooling::stdlib::Lang Lang = tooling::stdlib::Lang::CXX;
-if (LangOpts.C11)
- Lang = tooling::stdlib::Lang::C;
sorry i got confused, this also works for
VitaNuo added a comment.
Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156659/new/
https://reviews.llvm.org/D156659
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
VitaNuo updated this revision to Diff 556130.
VitaNuo marked 2 inline comments as done.
VitaNuo added a comment.
Address the comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156659/new/
https://reviews.llvm.org/D156659
Files:
clang-tools-e
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:912
+if (Directives & Symbol::Import) {
+ if (auto IncludeHeader = HeaderFileURIs->getIncludeHeader(FID);
+ !IncludeHeader.empty()) {
VitaNuo wrote:
>
VitaNuo added inline comments.
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:912
+if (Directives & Symbol::Import) {
+ if (auto IncludeHeader = HeaderFileURIs->getIncludeHeader(FID);
+ !IncludeHeader.empty()) {
kadircet wrote:
>
VitaNuo updated this revision to Diff 556004.
VitaNuo marked 5 inline comments as done.
VitaNuo added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156659/new/
https://reviews.llvm.org/D156659
Files:
clang-too
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:840
-if (S->Scope == "std::" && S->Name == "move") {
- if (!S->Signature.contains(','))
-return "";
- return "";
-}
-
-if (auto StdSym = tooling::stdl
VitaNuo created this revision.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
VitaNuo requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added projects: clang, clang-tools-extra.
Repository:
rG LLVM Github Monorepo
12 matches
Mail list logo