[PATCH] D156693: [clang][ASTImporter]Skip check friend template depth

2023-08-08 Thread Qizhi Hu via Phabricator via cfe-commits
jcsxky added a comment. In D156693#4568941 , @balazske wrote: > This fix can cause problems because the depth comparison is omitted all > times. It would be better to omit depth check if the imported template is a > friend, and has a

[PATCH] D156693: [clang][ASTImporter]Skip check friend template depth

2023-08-08 Thread Qizhi Hu via Phabricator via cfe-commits
jcsxky updated this revision to Diff 548166. jcsxky edited the summary of this revision. jcsxky added a comment. update diff: add more conditions on when to ignore comparing depth of two template classes to minimize influence to others and fix name of test case to make easy understanding

[PATCH] D156693: [clang][ASTImporter]Skip check friend template depth

2023-08-08 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. This fix can cause problems because the depth comparison is omitted all times. It would be better to omit depth check if the imported template is a friend, and has a `ClassTemplateSpecializationDecl` as context. Probably even then it is possible to construct cases

[PATCH] D156693: [clang][ASTImporter]Skip check friend template depth

2023-08-05 Thread Qizhi Hu via Phabricator via cfe-commits
jcsxky updated this revision to Diff 547505. jcsxky added a comment. clean unittest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156693/new/ https://reviews.llvm.org/D156693 Files: clang/include/clang/AST/ASTStructuralEquivalence.h