AntonRydahl created this revision.
AntonRydahl added a reviewer: jdoerfert.
Herald added subscribers: sunshaoce, guansong, yaxunl.
Herald added a reviewer: sscalpone.
Herald added a reviewer: awarzynski.
Herald added projects: Flang, All.
AntonRydahl requested review of this revision.
Herald added
tianshilei1992 added inline comments.
Comment at: flang/test/Driver/driver-help.f90:55
! HELP-NEXT: -fopenmp-version=
-! HELP-NEXT:Set OpenMP version (e.g. 45 for OpenMP
4.5, 50 for OpenMP 5.0). Default value is 50 for Clang and 11 for Flang
+! HELP-NEXT
AntonRydahl updated this revision to Diff 546477.
AntonRydahl added a comment.
I was a bit too fast. I changed OpenMPSupport.rst to point to both the OpenMP
5.0 and OpenMP 5.1 implementation status.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156
AntonRydahl added inline comments.
Comment at: flang/test/Driver/driver-help.f90:55
! HELP-NEXT: -fopenmp-version=
-! HELP-NEXT:Set OpenMP version (e.g. 45 for OpenMP
4.5, 50 for OpenMP 5.0). Default value is 50 for Clang and 11 for Flang
+! HELP-NEXT:
clementval added inline comments.
Comment at: flang/test/Driver/driver-help.f90:55
! HELP-NEXT: -fopenmp-version=
-! HELP-NEXT:Set OpenMP version (e.g. 45 for OpenMP
4.5, 50 for OpenMP 5.0). Default value is 50 for Clang and 11 for Flang
+! HELP-NEXT:
tianshilei1992 added inline comments.
Comment at: flang/test/Driver/driver-help.f90:55
! HELP-NEXT: -fopenmp-version=
-! HELP-NEXT:Set OpenMP version (e.g. 45 for OpenMP
4.5, 50 for OpenMP 5.0). Default value is 50 for Clang and 11 for Flang
+! HELP-NEXT
jdoerfert added inline comments.
Comment at: flang/test/Driver/driver-help.f90:55
! HELP-NEXT: -fopenmp-version=
-! HELP-NEXT:Set OpenMP version (e.g. 45 for OpenMP
4.5, 50 for OpenMP 5.0). Default value is 50 for Clang and 11 for Flang
+! HELP-NEXT:
clementval added inline comments.
Comment at: flang/test/Driver/driver-help.f90:55
! HELP-NEXT: -fopenmp-version=
-! HELP-NEXT:Set OpenMP version (e.g. 45 for OpenMP
4.5, 50 for OpenMP 5.0). Default value is 50 for Clang and 11 for Flang
+! HELP-NEXT:
AntonRydahl updated this revision to Diff 546964.
AntonRydahl added a comment.
Removing information about Flang default version of OpenMP.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156901/new/
https://reviews.llvm.org/D156901
Files:
clang/do
AntonRydahl added a comment.
The unit test that fails, `flang/test/Driver/omp-driver-offload.f90`, also
fails on main. I don't see that it should be related to this patch.
Comment at: flang/test/Driver/driver-help.f90:55
! HELP-NEXT: -fopenmp-version=
-! HELP-NEXT:
AntonRydahl updated this revision to Diff 547065.
AntonRydahl added a comment.
Removed whitespace that caused CI tests to fail.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156901/new/
https://reviews.llvm.org/D156901
Files:
clang/docs/OpenMPSu
AntonRydahl updated this revision to Diff 554049.
AntonRydahl added a comment.
Rebased on main.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156901/new/
https://reviews.llvm.org/D156901
Files:
clang/docs/OpenMPSupport.rst
clang/include/clang/
This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc1b5674fbb76: [OpenMP] Change OpenMP default version in
documentation and help text for… (authored by AntonRydahl).
Repos
13 matches
Mail list logo