eugenis created this revision.
eugenis added reviewers: pcc, kcc.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
- Runtime diagnostic data for cfi-icall changed to match the rest of cfi checks
- Layout of all CFI diagnostic data changed to put Kin
pcc added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2620
@@ +2619,3 @@
+ Builder.CreateICmpEQ(Data, llvm::ConstantPointerNull::get(Int8PtrTy));
+ Builder.CreateCondBr(DataIsNullPtr, TrapBB, ContBB);
+
This looks like `CodeGenFunction::EmitTrapCheck
eugenis updated this revision to Diff 44805.
eugenis marked 2 inline comments as done.
Repository:
rL LLVM
http://reviews.llvm.org/D15699
Files:
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
lib/CodeGen/CodeGenModule.cpp
lib/Driver/Tools.cpp
test/Code
eugenis added inline comments.
Comment at: lib/CodeGen/CGExpr.cpp:2654-2678
@@ +2653,27 @@
+ for (auto CheckKindMaskPair : CheckKinds) {
+int Kind = CheckKindMaskPair.first;
+SanitizerMask Mask = CheckKindMaskPair.second;
+// All CFI checks are recoverable.
+asser
eugenis updated this revision to Diff 45292.
Repository:
rL LLVM
http://reviews.llvm.org/D15699
Files:
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
lib/CodeGen/CodeGenModule.cpp
lib/Driver/Tools.cpp
test/CodeGen/cfi-check-fail.c
test/CodeGen/cfi-ic
eugenis added a comment.
ping
Repository:
rL LLVM
http://reviews.llvm.org/D15699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: test/CodeGen/cfi-check-fail.c:17
@@ +16,3 @@
+
+// CHECK: [[TRAP]]:
+// CHECK-NEXT: call void @llvm.trap()
Does this match in a -asserts build?
eugenis updated this revision to Diff 45920.
Repository:
rL LLVM
http://reviews.llvm.org/D15699
Files:
lib/CodeGen/CGClass.cpp
lib/CodeGen/CGExpr.cpp
lib/CodeGen/CodeGenFunction.h
lib/CodeGen/CodeGenModule.cpp
lib/Driver/Tools.cpp
test/CodeGen/cfi-check-fail.c
test/CodeGen/cfi-ic
eugenis added inline comments.
Comment at: test/CodeGen/cfi-check-fail.c:18
@@ +17,3 @@
+// CHECK: [[TRAP]]
+// CHECK-NEXT: call void @llvm.trap()
+// CHECK-NEXT: unreachable
Right.
It fails.
I've removed the ":" after all label names.
Repository:
rL LLVM
eugenis closed this revision.
eugenis added a comment.
Thanks! Committed as
http://reviews.llvm.org/rL258745
Repository:
rL LLVM
http://reviews.llvm.org/D15699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
10 matches
Mail list logo