This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7ba37f4e46a5: [clang][ExtractAPI] Add support for C++ class
templates and concepts (authored by evelez7).
Repository:
rG LLVM Github Monorepo
evelez7 updated this revision to Diff 551591.
evelez7 added a comment.
Fix formatting for introduced declarations in DeclarationFragments.h
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157076/new/
https://reviews.llvm.org/D157076
Files:
dang accepted this revision.
dang added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157076/new/
https://reviews.llvm.org/D157076
___
evelez7 updated this revision to Diff 550945.
evelez7 added a comment.
Also rename traverseSpec* in SerializerBase.h
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157076/new/
https://reviews.llvm.org/D157076
Files:
evelez7 added a comment.
We didn't handle inheriting from a template parameter, but now we do by
serializing the relationship. The parameter does not produce a target USR so it
falls back to its name.
Comment at: clang/include/clang/ExtractAPI/DeclarationFragments.h:191
evelez7 updated this revision to Diff 550937.
evelez7 marked 5 inline comments as done.
evelez7 added a comment.
Address review feedback
- Handle inheriting from a template parameter.
- Add a new test to check inheriting from a template parameter.
- Move base class gathering to a new private
dang added a comment.
Looks mostly good. Quick Question how do we handle inheritance to a template
parameter?
Comment at: clang/include/clang/ExtractAPI/API.h:665
+
+struct ClassTemplateSpecRecord : CXXClassRecord {
+ ClassTemplateSpecRecord(StringRef USR, StringRef Name,
evelez7 updated this revision to Diff 548862.
evelez7 added a comment.
Fix template arg identification
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157076/new/
https://reviews.llvm.org/D157076
Files:
clang/include/clang/ExtractAPI/API.h
evelez7 updated this revision to Diff 548042.
evelez7 added a comment.
Add brackets for SerializerBase visit methods
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157076/new/
https://reviews.llvm.org/D157076
Files:
evelez7 updated this revision to Diff 547971.
evelez7 added a comment.
Refactor template arg name deduction to get as string for
FragmentKind::typeIdentifier
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157076/new/
evelez7 updated this revision to Diff 547389.
evelez7 added a comment.
Abstract the name deduction for generic template args to its own function. It's
very helpful in other cases.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157076/new/
evelez7 updated this revision to Diff 547314.
evelez7 added a comment.
Add documentation to template argument name deduction, add missing method
declarations to visitor base
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157076/new/
evelez7 updated this revision to Diff 547265.
evelez7 added a comment.
Format DeclarationFragments.h, try to address buildbot fail on clang-format
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157076/new/
https://reviews.llvm.org/D157076
Files:
evelez7 created this revision.
evelez7 added a reviewer: dang.
Herald added a reviewer: ributzka.
Herald added a project: All.
evelez7 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Add has_template template, DeclarationFragmentBuilder
14 matches
Mail list logo
