[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

2023-08-08 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. In D157119#4569967 , @vitalybuka wrote: > In D157119#4569725 , @jroelofs > wrote: > >> Flaky test? Here's a later build where it succeeds, but the change has >> nothing to do with cl

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

2023-08-08 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. In D157119#4569725 , @jroelofs wrote: > Flaky test? Here's a later build where it succeeds, but the change has > nothing to do with clangd: > https://lab.llvm.org/buildbot/#/builders/168/builds/14997 No, I manually requested

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

2023-08-08 Thread Jon Roelofs via Phabricator via cfe-commits
jroelofs added a comment. Flaky test? Here's a later build where it succeeds, but the change has nothing to do with clangd: https://lab.llvm.org/buildbot/#/builders/168/builds/14997 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/ https:/

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

2023-08-07 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. > How to reproduce locally: > https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild Does not reproduce on my workstation too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/ https://reviews

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

2023-08-07 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. In D157119#4565993 , @jroelofs wrote: > In D157119#4564546 , @vitalybuka > wrote: > >> I suspect one of your recent changes broke >> https://lab.llvm.org/buildbot/#/builders/168/build

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

2023-08-07 Thread Jon Roelofs via Phabricator via cfe-commits
jroelofs added a comment. In D157119#4564546 , @vitalybuka wrote: > I suspect one of your recent changes broke > https://lab.llvm.org/buildbot/#/builders/168/builds/14944 > Can you please take a look? Happy to take a look, but there are 28 commits in t

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

2023-08-06 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. I suspect one of your recent changes broke https://lab.llvm.org/buildbot/#/builders/168/builds/14944 Can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/ https://reviews.llvm.org/D157119

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

2023-08-04 Thread Jon Roelofs via Phabricator via cfe-commits
jroelofs added a comment. missed one more: 3d756c32cdf005d0f4c05f561fec4a37b64b7ddd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/ https://reviews.llvm.org/D157119 _

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

2023-08-04 Thread Jon Roelofs via Phabricator via cfe-commits
jroelofs added a comment. back-porting to the release branch: https://github.com/llvm/llvm-project/issues/64432 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/ https://reviews.llvm.org/D157119 ___

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

2023-08-04 Thread Jon Roelofs via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2fb1c1082c01: cmake: add missing dependencies on ClangDriverOptions tablegen (authored by jroelofs). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

2023-08-04 Thread Steven Wu via Phabricator via cfe-commits
steven_wu accepted this revision. steven_wu added subscribers: aprantl, dblaikie. steven_wu added a comment. This revision is now accepted and ready to land. LGTM. @aprantl @dblaikie who cares about module builds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

2023-08-04 Thread Jon Roelofs via Phabricator via cfe-commits
jroelofs added a comment. related discussion: https://discourse.llvm.org/t/rfc-permanently-fixing-the-missing-tablegen-dependency-issue/70442/14 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157119/new/ https://reviews.llvm.org/D157119 __

[PATCH] D157119: cmake: add missing dependencies on ClangDriverOptions tablegen

2023-08-04 Thread Jon Roelofs via Phabricator via cfe-commits
jroelofs created this revision. jroelofs added a reviewer: steven_wu. Herald added subscribers: PiotrZSL, kadircet, steakhal, carlosgalvezp, abrachet, martong, arphaman, kbarton, nemanjai. Herald added a reviewer: NoQ. Herald added a reviewer: njames93. Herald added a project: All. jroelofs reques