ddpagan abandoned this revision.
ddpagan added a comment.
Change no longer needed per review/comments.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157197/new/
https://reviews.llvm.org/D157197
___
cfe-commits mailing list
cfe-commits@lists.l
ddpagan added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1570-1575
+ // If we are here with a 'target teams loop' then we are emitting the
+ // 'parallel' region of the 'target teams distribute parallel for'
+ // emitted in place of the 'target teams loop'
ABataev added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1570-1575
+ // If we are here with a 'target teams loop' then we are emitting the
+ // 'parallel' region of the 'target teams distribute parallel for'
+ // emitted in place of the 'target teams loop'
ddpagan added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1570-1575
+ // If we are here with a 'target teams loop' then we are emitting the
+ // 'parallel' region of the 'target teams distribute parallel for'
+ // emitted in place of the 'target teams loop'
ABataev added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1570-1575
+ // If we are here with a 'target teams loop' then we are emitting the
+ // 'parallel' region of the 'target teams distribute parallel for'
+ // emitted in place of the 'target teams loop'
ddpagan added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1570-1575
+ // If we are here with a 'target teams loop' then we are emitting the
+ // 'parallel' region of the 'target teams distribute parallel for'
+ // emitted in place of the 'target teams loop'
ABataev added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1570-1575
+ // If we are here with a 'target teams loop' then we are emitting the
+ // 'parallel' region of the 'target teams distribute parallel for'
+ // emitted in place of the 'target teams loop'
ddpagan added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1570-1575
+ // If we are here with a 'target teams loop' then we are emitting the
+ // 'parallel' region of the 'target teams distribute parallel for'
+ // emitted in place of the 'target teams loop'
ABataev added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1570-1575
+ // If we are here with a 'target teams loop' then we are emitting the
+ // 'parallel' region of the 'target teams distribute parallel for'
+ // emitted in place of the 'target teams loop'
ddpagan updated this revision to Diff 547982.
ddpagan added a comment.
As requested, added reference to OpenMP 5.2 specification that discusses
handling of if clauses with combined/composite directives. Also, improved
comment relating to what was being done and why.
CHANGES SINCE LAST ACTION
ddpagan added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1564
+ // Any if-clause associated with expansion for 'target teams loop' should
+ // apply to target region only. OpenMP 5.2 [3.4, if Clause, Semantics, 15-18]
+ if (S.getDirectiveKind() != OMPD_tar
ABataev added inline comments.
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:1564
+ // Any if-clause associated with expansion for 'target teams loop' should
+ // apply to target region only. OpenMP 5.2 [3.4, if Clause, Semantics, 15-18]
+ if (S.getDirectiveKind() != OMPD_tar
ddpagan updated this revision to Diff 547515.
ddpagan added a comment.
Added reference to relevant portion of the OpenMP 5.2 specification.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157197/new/
https://reviews.llvm.org/D157197
Files:
clang/lib/CodeGen/CGStmtOpenMP.cpp
clang/tes
ABataev added a comment.
Add the reference to openmp spec
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157197/new/
https://reviews.llvm.org/D157197
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
ddpagan created this revision.
ddpagan added a reviewer: ABataev.
ddpagan added projects: clang, OpenMP.
Herald added subscribers: guansong, yaxunl.
Herald added a project: All.
ddpagan requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: cfe-commits, jpl
15 matches
Mail list logo