[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae84ad15efd7: [Driver] Select newest GCC installation on Solaris (authored by ro). Changed prior to commit:

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2258 - Prefixes.push_back(CandidatePrefix); + SolarisPrefixes.push_back(CandidatePrefix); }

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro updated this revision to Diff 550226. ro marked an inline comment as done. ro added a comment. Herald added a subscriber: ormris. - Simplify `SolarisPrefixes` sorting. - Switch to unitest`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro marked an inline comment as done. ro added a comment. In D157275#4585184 , @MaskRay wrote: > Thanks for the update. Regarding testing, it seems that unittests will be > more convenience than creating so many placeholder files in `Inputs/`. >

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

MaskRay added a comment. Thanks for the update. Regarding testing, it seems that unittests will be more convenience than creating so many placeholder files in `Inputs/`. `clang/unittests/Driver/ToolChainTest.cpp` `TEST(ToolChainTest, VFSGCCInstallation)` has an example for Linux. You can add

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro updated this revision to Diff 549925. ro added a comment. Herald added a subscriber: mgrang. Updated based on discussions in Issue #53709: - Sort Solaris GCC prefixes in reverse version order so the latest version is picked. - Update testcase to match. Tested on `amd64-pc-solaris2.11` and

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2193 // Skip other prefixes once a GCC installation is found. -if (Version > VersionZero) +// Solaris GCC installations live in separate Prefixes per Version +// (/usr/gcc/) that arrive in

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2193 // Skip other prefixes once a GCC installation is found. -if (Version > VersionZero) +// Solaris GCC installations live in separate Prefixes per Version +// (/usr/gcc/) that

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: pengfei, jrtc27, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. As described in Issue #53709