This revision was automatically updated to reflect the committed changes.
Closed by commit rG818e76d6f2dd: [RISCV] Add MC layer support for Zicfilp.
(authored by fakepaper56).
Changed prior to commit:
https://reviews.llvm.org/D157362?vs=550089=550562#toc
Repository:
rG LLVM Github Monorepo
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157362/new/
https://reviews.llvm.org/D157362
fakepaper56 updated this revision to Diff 550089.
fakepaper56 added a comment.
Address comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157362/new/
https://reviews.llvm.org/D157362
Files:
clang/test/Preprocessor/riscv-target-features.c
craig.topper added inline comments.
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.td:665
+let Predicates = [HasStdExtZicfilp] in {
+def : InstAlias<"lpad $imm20", (AUIPC X0, uimm20:$imm20)>;
There is a designated spot in this file for InstAliases.
reames added inline comments.
Comment at: llvm/docs/RISCVUsage.rst:120
``Zicboz`` Assembly Support
+ ``Zicfilp`` Assembly Support
``Zicntr`` (`See Note <#riscv-i2p1-note>`__)
This in the wrong place; this is not a ratified
fakepaper56 updated this revision to Diff 549262.
fakepaper56 added a comment.
Update docs/RISCVUsage.rst.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157362/new/
https://reviews.llvm.org/D157362
Files: