[PATCH] D157394: [clang][DeclPrinter] Improve AST print of function attributes

strimo378 added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:267 +// C2x/C++11-style attributes must appear before the declarator. +if (S == Attr::AS_CXX11 || S == Attr::AS_C2x) + return AttrLocation::BeforeDecl; strimo378 wrote: >

[PATCH] D157394: [clang][DeclPrinter] Improve AST print of function attributes

strimo378 updated this revision to Diff 548916. strimo378 added a comment. Added more test cases and considering __declspec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157394/new/ https://reviews.llvm.org/D157394 Files:

[PATCH] D157394: [clang][DeclPrinter] Improve AST print of function attributes

strimo378 added a comment. In D157394#4572777 , @giulianobelinassi wrote: > This patch do not address attributes in variables nor the __declspec case, as > D141714 do. His patch looks cleaner and I > can surely

[PATCH] D157394: [clang][DeclPrinter] Improve AST print of function attributes

giulianobelinassi added inline comments. Comment at: clang/lib/AST/DeclPrinter.cpp:259 +case attr::Final: +case attr::Override: + return AttrLocation::AfterDecl; aaron.ballman wrote: > giulianobelinassi wrote: > > @aaron.ballman @erichkeane > > >

[PATCH] D157394: [clang][DeclPrinter] Improve AST print of function attributes

aaron.ballman added a comment. In D157394#4572777 , @giulianobelinassi wrote: > This patch do not address attributes in variables nor the __declspec case, as > D141714 do. His patch looks cleaner and I > can surely

[PATCH] D157394: [clang][DeclPrinter] Improve AST print of function attributes

giulianobelinassi added subscribers: erichkeane, giulianobelinassi. giulianobelinassi added a comment. This patch do not address attributes in variables nor the __declspec case, as D141714 do. His patch looks cleaner and I can surely coordinate with @strimo378

[PATCH] D157394: [clang][DeclPrinter] Improve AST print of function attributes

strimo378 updated this revision to Diff 548487. strimo378 edited the summary of this revision. strimo378 added a comment. Using Attr::getSyntax function (instead of unnecessarly added Attr::getVariety function) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157394: [clang][DeclPrinter] Improve AST print of function attributes

aaron.ballman added a comment. This is looking to make similar changes to the ones proposed in https://reviews.llvm.org/D141714 -- can you coordinate with the other author so there's only one review that covers both needs? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION