This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG421c9bbf65b7: [NFC][Clang] Fix static analyzer concern
(authored by eandrews).
Herald added a project: clang.
Repository:
rG LLVM Github Monorepo
eandrews added a comment.
Pre-merge check fails are unrelated - fatal error C1060: compiler is out of
heap space
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157454/new/
https://reviews.llvm.org/D157454
___
cfe-commits mailing list
cfe-comm
tahonermann accepted this revision.
tahonermann added a comment.
Looks good to me. Thanks, Elizabeth!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157454/new/
https://reviews.llvm.org/D157454
___
cfe-commits mailing list
cfe-commits@lists.ll
eandrews updated this revision to Diff 548789.
eandrews added a comment.
Applied review comments to use an assert instead
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157454/new/
https://reviews.llvm.org/D157454
Files:
clang/lib/CodeGen/CGObjC.cpp
Index: clang/lib/CodeGen/CGObjC.c
tahonermann added inline comments.
Comment at: clang/lib/CodeGen/CGObjC.cpp:222-223
Selector Sel = MethodWithObjects->getSelector();
- QualType ResultType = E->getType();
- const ObjCObjectPointerType *InterfacePointerType
-= ResultType->getAsObjCInterfacePointerType();
eandrews added inline comments.
Comment at: clang/lib/CodeGen/CGObjC.cpp:222-223
Selector Sel = MethodWithObjects->getSelector();
- QualType ResultType = E->getType();
- const ObjCObjectPointerType *InterfacePointerType
-= ResultType->getAsObjCInterfacePointerType();
+
tahonermann added inline comments.
Comment at: clang/lib/CodeGen/CGObjC.cpp:222-223
Selector Sel = MethodWithObjects->getSelector();
- QualType ResultType = E->getType();
- const ObjCObjectPointerType *InterfacePointerType
-= ResultType->getAsObjCInterfacePointerType();
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157454/new/
https://reviews.llvm.org/D157454
___
cfe-commits mailing list
eandrews created this revision.
eandrews added reviewers: aaron.ballman, tahonermann.
Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus,
a.sidorin, baloghadamsoftware.
Herald added a project: All.
eandrews requested review of this revision.
InterfacePointerType is dere
