This revision was automatically updated to reflect the committed changes.
Closed by commit rGba475a4a3440: [clang-repl] Disambiguate global namespace
identifiers (authored by Hahnfeld).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157480/new/
https
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157480/new/
https://reviews.llvm.org/D157480
___
cfe-commits mailing list
Hahnfeld added inline comments.
Comment at: clang/test/Interpreter/global-namespace-disambiguate.cpp:6
+struct A { ~A(); };
+::A::~A() {}
+
v.g.vassilev wrote:
> Can we add this test to `disambiguate-decl-stmt.cpp` instead where we track
> these things?
done
C
Hahnfeld updated this revision to Diff 548562.
Hahnfeld marked an inline comment as done.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157480/new/
https://reviews.llvm.org/D157480
Files:
clang/lib/Parse/ParseTentative.cpp
clang/test/Interpreter/disambiguate-decl-stmt.cpp
Index: cl
v.g.vassilev added inline comments.
Comment at: clang/test/Interpreter/global-namespace-disambiguate.cpp:6
+struct A { ~A(); };
+::A::~A() {}
+
Can we add this test to `disambiguate-decl-stmt.cpp` instead where we track
these things?
Repository:
rG LLVM Gith
Hahnfeld created this revision.
Hahnfeld added reviewers: v.g.vassilev, aaron.ballman.
Herald added a project: All.
Hahnfeld requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
A double colon starts an identifier name in the global namespace an
