[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

eandrews added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157554/new/ https://reviews.llvm.org/D157554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

This revision was automatically updated to reflect the committed changes. Closed by commit rGc4ada13e4b3e: [NFC][Clang] Fix static analyzer concern about null value dereference (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157554/new/ https://reviews.llvm.org/D157554 ___ cfe-commits

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

eandrews updated this revision to Diff 549960. eandrews added a comment. Applied review comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157554/new/ https://reviews.llvm.org/D157554 Files: clang/lib/Sema/SemaExprCXX.cpp Index: clang/lib/Sema/SemaExprCXX.cpp

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

eandrews added a comment. In D157554#4577504 , @aaron.ballman wrote: > In D157554#4576720 , @eandrews > wrote: > >> In D157554#4576478 , >> @aaron.ballman wrote: >>

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

aaron.ballman added a comment. In D157554#4576720 , @eandrews wrote: > In D157554#4576478 , @aaron.ballman > wrote: > >> This feels a bit more like a functional change than a non-functional change >> because it

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

eandrews added a comment. In D157554#4576478 , @aaron.ballman wrote: > This feels a bit more like a functional change than a non-functional change > because it seems like we should be able to test this case (whereas, if we > think `TC` can never be

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

aaron.ballman added a reviewer: erichkeane. aaron.ballman added a subscriber: erichkeane. aaron.ballman added a comment. This feels a bit more like a functional change than a non-functional change because it seems like we should be able to test this case (whereas, if we think `TC` can never be

[PATCH] D157554: [NFC][Clang] Fix static analyzer concern about null pointer dereference

eandrews created this revision. eandrews added reviewers: tahonermann, aaron.ballman. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. eandrews requested review of this revision. Herald added a subscriber: