[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

philnik abandoned this revision. philnik added a comment. Abandoning, since it seems like we want to extend `diagnose_if` instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157572/new/ https://reviews.llvm.org/D157572

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

cjdb added a comment. Started a thread: https://discourse.llvm.org/t/exposing-the-diagnostic-engine-to-c/73092 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157572/new/ https://reviews.llvm.org/D157572

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

cjdb added a comment. In D157572#4617504 , @aaron.ballman wrote: > In D157572#4614561 , @cjdb wrote: > >> In D157572#4613622 , >> @aaron.ballman wrote: >> >>> In

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

philnik added a comment. In D157572#4617504 , @aaron.ballman wrote: > In D157572#4614561 , @cjdb wrote: > >> In D157572#4613622 , >> @aaron.ballman wrote: >> >>> In

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

aaron.ballman added a subscriber: Mordante. aaron.ballman added a comment. In D157572#4614561 , @cjdb wrote: > In D157572#4613622 , @aaron.ballman > wrote: > >> In D157572#4612141

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

cjdb added a comment. In D157572#4613622 , @aaron.ballman wrote: > In D157572#4612141 , @cjdb wrote: > >> I don't dislike it, but I am a bit concerned about misuse being noisy. > > So you're concerned that a

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

aaron.ballman added a comment. In D157572#4612141 , @cjdb wrote: > I don't dislike it, but I am a bit concerned about misuse being noisy. So you're concerned that a library author uses `diagnose_if` to add a diagnostic to a warning group that makes the

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

cjdb added a comment. In D157572#4606513 , @aaron.ballman wrote: > In D157572#4604595 , @philnik wrote: > >> In D157572#4604482 , >> @aaron.ballman wrote: >> This

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

philnik added a comment. In D157572#4606513 , @aaron.ballman wrote: > In D157572#4604595 , @philnik wrote: > >> In D157572#4604482 , >> @aaron.ballman wrote: >>

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

aaron.ballman added a comment. In D157572#4604595 , @philnik wrote: > In D157572#4604482 , @aaron.ballman > wrote: > >>> This allows standard libraries to mark symbols as extensions, so the >>> compiler can

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

philnik added a comment. In D157572#4604482 , @aaron.ballman wrote: >> This allows standard libraries to mark symbols as extensions, so the >> compiler can generate extension warnings when they are used. > > Huh, so this is basically the opposite of

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

aaron.ballman added a comment. > This allows standard libraries to mark symbols as extensions, so the compiler > can generate extension warnings when they are used. Huh, so this is basically the opposite of the `__extension__` macro (which is used to silence extension warnings)? I don't think

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

ldionne added a comment. I think I like this attribute. However, I am concerned that this would make it seem more acceptable to add extensions to the library, when our policy has been that we don't (and for good reasons, we ran into big issues with e.g. `std::string_view` and we learned from

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

philnik added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5690-5691 +def warn_unknown_ext : Warning<"Unknown extension kind: %0">; +def warn_cxx11_ext : Warning<"%0 is a C++11 extension">, +InGroup; +def warn_cxx14_ext : Warning<"%0 is a

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5690-5691 +def warn_unknown_ext : Warning<"Unknown extension kind: %0">; +def warn_cxx11_ext : Warning<"%0 is a C++11 extension">, +InGroup; +def warn_cxx14_ext : Warning<"%0 is a C++14

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

philnik created this revision. philnik added reviewers: aaron.ballman, erichkeane. Herald added a subscriber: arphaman. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This allows standard libraries to