[PATCH] D157691: [ASTImporter] Remove extranous FunctionTemplateDecl introduced by templated friend

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGeabc7add1f96: [clang][ASTImporter] Remove extra FunctionTemplateDecl introduced by templated… (authored by dingfei ). Repository:

[PATCH] D157691: [ASTImporter] Remove extranous FunctionTemplateDecl introduced by templated friend

balazske accepted this revision. balazske added a comment. This revision is now accepted and ready to land. Additionally, use the "[clang][ASTImporter]" tags at commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157691/new/ https://revie

[PATCH] D157691: [ASTImporter] Remove extranous FunctionTemplateDecl introduced by templated friend

danix800 updated this revision to Diff 550210. danix800 added a comment. 1. Remove unnecessary testcase. 2. Format unittest code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157691/new/ https://reviews.llvm.org/D157691 Files: clang/lib/AST/AST

[PATCH] D157691: [ASTImporter] Remove extranous FunctionTemplateDecl introduced by templated friend

danix800 added a comment. In D157691#4587490 , @balazske wrote: > When committing this patch, the commit message should not contain the whole > AST and crash dump (phabricator takes the "summary" text), this looks too > much in a commit message. One AST

[PATCH] D157691: [ASTImporter] Remove extranous FunctionTemplateDecl introduced by templated friend

balazske added a comment. When committing this patch, the commit message should not contain the whole AST and crash dump (phabricator takes the "summary" text), this looks too much in a commit message. One AST dump from the wrong To AST is enough. Comment at: clang/test/Impor

[PATCH] D157691: [ASTImporter] Remove extranous FunctionTemplateDecl introduced by templated friend

danix800 updated this revision to Diff 550160. danix800 added a comment. 1. Add unit testcase 2. Use better API Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157691/new/ https://reviews.llvm.org/D157691 Files: clang/lib/AST/ASTImporter.cpp cla

[PATCH] D157691: [ASTImporter] Remove extranous FunctionTemplateDecl introduced by templated friend

balazske added a comment. It is better to add a test to ASTImporterTests.cpp with the same code, and check the properties of DeclContext and LexicalDeclContext in the From and To AST (should be the same in "From" and "To" side). Comment at: clang/lib/AST/ASTImporter.cpp:6451

[PATCH] D157691: [ASTImporter] Remove extranous FunctionTemplateDecl introduced by templated friend

danix800 created this revision. danix800 added reviewers: balazske, aaron.ballman. danix800 added a project: clang. Herald added subscribers: pengfei, martong, kristof.beyls. Herald added a reviewer: a.sidorin. Herald added a reviewer: shafik. Herald added a project: All. danix800 requested review