[PATCH] D157747: Support Unicode Microsoft predefined macros

2023-08-31 Thread Richard Dzenis via Phabricator via cfe-commits
RIscRIpt abandoned this revision. RIscRIpt added a comment. I found a way to implement `__LPREFIX`-macros-family in Clang. I need some more time to finish and polish it. Going to post it a couple of weeks later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D157747: Support Unicode Microsoft predefined macros

2023-08-23 Thread Richard Dzenis via Phabricator via cfe-commits
RIscRIpt planned changes to this revision. RIscRIpt added a comment. While I work at `__LPREFIX`, I remove this revision from review queue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157747/new/ https://reviews.llvm.org/D157747

[PATCH] D157747: Support Unicode Microsoft predefined macros

2023-08-22 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D157747#4581933 , @cor3ntin wrote: > This does not appear to be valid under MSVC and I don't think we should > support features that MS does not (Nor can i find any documentation that it > ought to work) >

[PATCH] D157747: Support Unicode Microsoft predefined macros

2023-08-12 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin added a comment. This does not appear to be valid under MSVC and I don't think we should support features that MS does not (Nor can i find any documentation that it ought to work) https://godbolt.org/z/7Te3YYeb9 Supporting the same concatenation behavior MSVC does have seem like a

[PATCH] D157747: Support Unicode Microsoft predefined macros

2023-08-11 Thread Richard Dzenis via Phabricator via cfe-commits
RIscRIpt added a comment. This implementation preserves support for identifiers `L__FUNCSIG__` and `L__FUNCTION__` (which have never been supported by MSVC), and adds other identifiers for all supported encodings: L, u8, u, U. If breaking backwards compatibility in clang (with Microsoft

[PATCH] D157747: Support Unicode Microsoft predefined macros

2023-08-11 Thread Richard Dzenis via Phabricator via cfe-commits
RIscRIpt created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, martong. Herald added a reviewer: shafik. Herald added a reviewer: njames93. Herald added a project: All. RIscRIpt requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a