[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

bogner created this revision. bogner added reviewers: rnk, jansvoboda11, MaskRay. Herald added subscribers: jeroen.dobbelaere, mcrosier. Herald added a project: All. bogner requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The -g flag has bee

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

rnk added a subscriber: smeenai. rnk added inline comments. Comment at: clang/test/Driver/cl-options.c:567 -// This test was super sneaky: "/Z7" means "line-tables", but "-gdwarf" occurs -// later on the command line, so it should win. Interestingly the cc1 arguments -// came o

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

bogner added inline comments. Comment at: clang/test/Driver/cl-options.c:567 -// This test was super sneaky: "/Z7" means "line-tables", but "-gdwarf" occurs -// later on the command line, so it should win. Interestingly the cc1 arguments -// came out right, but had wrong semant

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

smeenai added inline comments. Comment at: clang/test/Driver/cl-options.c:567 -// This test was super sneaky: "/Z7" means "line-tables", but "-gdwarf" occurs -// later on the command line, so it should win. Interestingly the cc1 arguments -// came out right, but had wrong seman

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

bogner added inline comments. Comment at: clang/test/Driver/cl-options.c:567 -// This test was super sneaky: "/Z7" means "line-tables", but "-gdwarf" occurs -// later on the command line, so it should win. Interestingly the cc1 arguments -// came out right, but had wrong semant

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

smeenai added a subscriber: mstorsjo. smeenai added inline comments. Comment at: clang/test/Driver/cl-options.c:567 -// This test was super sneaky: "/Z7" means "line-tables", but "-gdwarf" occurs -// later on the command line, so it should win. Interestingly the cc1 arguments -

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. So, as I understand the discussion, after this patch, it will still be possible to get dwarf and codeview in the same compile, but users will have to resort to cc1 flags. I think that's a good end

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:4522 RenderDebugInfoCompressionArgs(Args, CmdArgs, D, TC); + + Keep just one blank line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

mstorsjo added inline comments. Comment at: clang/test/Driver/cl-options.c:567 -// This test was super sneaky: "/Z7" means "line-tables", but "-gdwarf" occurs -// later on the command line, so it should win. Interestingly the cc1 arguments -// came out right, but had wrong sema

[PATCH] D157794: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf58330cbe445: [Driver] Make /Zi and /Z7 aliases of -g rather than handling them specially (authored by bogner). Changed prior to commit: https://r