[PATCH] D158031: [clang][ExtractAPI] Refactor C++ method and field visitation

2023-08-21 Thread Erick Velez via Phabricator via cfe-commits
evelez7 added a comment. In D158031#4603363 , @dang wrote: > Did this change not affect ordering of the symbols in the generated JSON? > Looks pretty good to me otherwise! It only changed method ordering due to them not being grouped together, so insta

[PATCH] D158031: [clang][ExtractAPI] Refactor C++ method and field visitation

2023-08-21 Thread Erick Velez via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3bb485530869: [clang][ExtractAPI] Refactor C++ method and field visitation (authored by evelez7). Changed prior to commit: https://reviews.llvm.or

[PATCH] D158031: [clang][ExtractAPI] Refactor C++ method and field visitation

2023-08-21 Thread Daniel Grumberg via Phabricator via cfe-commits
dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. Did this change not affect ordering of the symbols in the generated JSON? Looks pretty good to me otherwise! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D158031: [clang][ExtractAPI] Refactor C++ method and field visitation

2023-08-17 Thread Erick Velez via Phabricator via cfe-commits
evelez7 updated this revision to Diff 551212. evelez7 added a comment. Fix passing Decl's template, introduced from parent updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158031/new/ https://reviews.llvm.org/D158031 Files: clang/include/cl

[PATCH] D158031: [clang][ExtractAPI] Refactor C++ method and field visitation

2023-08-15 Thread Erick Velez via Phabricator via cfe-commits
evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Refactor visitation for C++ record children by following