hokein added a comment.
I'm wondering whether should we rename `CERT` to `cert` to keep the same with
other modules like misc and google.
For adding a new check in CERT module, you need to use the upper name
explicitly via `python add_new_check.py CERT foo` rather than `python
add_new_check.py
alexfh added a comment.
In http://reviews.llvm.org/D15805#317629, @hokein wrote:
> I'm wondering whether should we rename `CERT` to `cert` to keep the same
> with other modules like misc and google.
SGTM. Aaron, do you see any reasons not to do this?
Repository:
rL LLVM
http://reviews.ll
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Fine by me -- I went with CERT since it's an acronym, but we don't do this for
LLVM, so this change makes sense. Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D15805
alexfh added a comment.
In http://reviews.llvm.org/D15805#317657, @aaron.ballman wrote:
> Fine by me -- I went with CERT since it's an acronym, but we don't do this
> for LLVM, so this change makes sense. Thanks!
AFAIU, LLVM is not an acronym anymore ;) (but still an upper-case spelling is
th
aaron.ballman added a comment.
Fine by me -- I went with CERT since it's an acronym, but we don't do this for
LLVM, so this change makes sense. Thanks!
In http://reviews.llvm.org/D15805#317736, @alexfh wrote:
> In http://reviews.llvm.org/D15805#317657, @aaron.ballman wrote:
>
> > Fine by me --
hokein added a comment.
So shoud we need to rename to `cert` at this patch?
Repository:
rL LLVM
http://reviews.llvm.org/D15805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman added a comment.
In http://reviews.llvm.org/D15805#318307, @hokein wrote:
> So shoud we need to rename to `cert` at this patch?
Yes, but just the namespaces as you do in this patch (not anything in user
documentation, for instance). This patch LG; if you need me to commit on your
hokein updated this revision to Diff 43870.
hokein added a comment.
Rename: 'CERT' => 'cert'
http://reviews.llvm.org/D15805
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/SetLongJmpCheck.cpp
clang-tidy/cert/SetLongJmpCheck.h
clang-tidy/cert/StaticObjectExceptionCheck.cpp
cl
hokein added a comment.
> Yes, but just the namespaces as you do in this patch (not anything in user
> documentation, for instance). This patch LG; if you need me to commit on your
> behalf, I'm happy to do so.
Done. But My account has no write access to the code repo. Can I commit the
patch
aaron.ballman added a comment.
In http://reviews.llvm.org/D15805#318624, @hokein wrote:
> > Yes, but just the namespaces as you do in this patch (not anything in user
> > documentation, for instance). This patch LG; if you need me to commit on
> > your behalf, I'm happy to do so.
>
>
> Done. Bu
hokein added a comment.
In http://reviews.llvm.org/D15805#318646, @aaron.ballman wrote:
> In http://reviews.llvm.org/D15805#318624, @hokein wrote:
>
> > > Yes, but just the namespaces as you do in this patch (not anything in
> > > user documentation, for instance). This patch LG; if you need me
aaron.ballman closed this revision.
aaron.ballman added a comment.
I've commit in r256756, thanks!
http://reviews.llvm.org/D15805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
12 matches
Mail list logo
