bcraig created this revision.
bcraig added reviewers: mclow.lists, jroelofs, danalbert, EricWF.
bcraig added a subscriber: cfe-commits.
Herald added a subscriber: emaste.
This patch makes it easier to support running the lit tests for new and
unusual platforms. It will break existing users that s
jroelofs added a comment.
This is awesome!
LGTM with one nit: add a newline between each function definition, and two
between each class. It's a little crowded without that.
http://reviews.llvm.org/D15813
___
cfe-commits mailing list
cfe-commits@l
jroelofs added a comment.
> This patch makes it easier to support running the lit tests for new and
> unusual platforms. It will break existing users that set LIBCXX_TARGET_INFO
> to anything other than the default. I think this is fine, because the old
> LIBCXX_TARGET_INFO wasn't terribly usef
bcraig closed this revision.
bcraig added a comment.
Committed as r256588.
Thanks for the quick review!
http://reviews.llvm.org/D15813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF added a comment.
This is NOT correct and it's breaking bots. I don't want to revert it because
I really like the change but it needs to be fixed quickly.
@bcraig You removed the logic that tests if a system provides a given locale.
We use this information to enable/disable tests. Please
EricWF added a comment.
I re-added the feature myself in r256621.
http://reviews.llvm.org/D15813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcraig added a comment.
Apologies for the swarm of breakages this caused. Thanks for the late night
(for me at least) locale fix EricWF!
http://reviews.llvm.org/D15813
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
