sbc100 added inline comments.
Comment at: clang/CMakeLists.txt:179-183
+if(DEFAULT_SYSROOT)
+ message(WARNING "DEFAULT_SYSROOT is deprecated and will be removed. Use "
+"configuration files
(https://clang.llvm.org/docs/UsersManual.html#configuration-files)"
+"to specify
MaskRay added inline comments.
Comment at: clang/CMakeLists.txt:179-183
+if(DEFAULT_SYSROOT)
+ message(WARNING "DEFAULT_SYSROOT is deprecated and will be removed. Use "
+"configuration files
(https://clang.llvm.org/docs/UsersManual.html#configuration-files)"
+"to specif
bcain added inline comments.
Comment at: clang/CMakeLists.txt:179-183
+if(DEFAULT_SYSROOT)
+ message(WARNING "DEFAULT_SYSROOT is deprecated and will be removed. Use "
+"configuration files
(https://clang.llvm.org/docs/UsersManual.html#configuration-files)"
+"to specify
MaskRay added a subscriber: sbc100.
MaskRay added inline comments.
Comment at: clang/CMakeLists.txt:179-183
+if(DEFAULT_SYSROOT)
+ message(WARNING "DEFAULT_SYSROOT is deprecated and will be removed. Use "
+"configuration files
(https://clang.llvm.org/docs/UsersManual.html#c
MaskRay added inline comments.
Comment at: clang/CMakeLists.txt:179-183
+if(DEFAULT_SYSROOT)
+ message(WARNING "DEFAULT_SYSROOT is deprecated and will be removed. Use "
+"configuration files
(https://clang.llvm.org/docs/UsersManual.html#configuration-files)"
+"to specif
bcain added inline comments.
Comment at: clang/CMakeLists.txt:179-183
+if(DEFAULT_SYSROOT)
+ message(WARNING "DEFAULT_SYSROOT is deprecated and will be removed. Use "
+"configuration files
(https://clang.llvm.org/docs/UsersManual.html#configuration-files)"
+"to specify
MaskRay added inline comments.
Comment at: clang/CMakeLists.txt:179-183
+if(DEFAULT_SYSROOT)
+ message(WARNING "DEFAULT_SYSROOT is deprecated and will be removed. Use "
+"configuration files
(https://clang.llvm.org/docs/UsersManual.html#configuration-files)"
+"to specif
bcain added inline comments.
Comment at: clang/CMakeLists.txt:179-183
+if(DEFAULT_SYSROOT)
+ message(WARNING "DEFAULT_SYSROOT is deprecated and will be removed. Use "
+"configuration files
(https://clang.llvm.org/docs/UsersManual.html#configuration-files)"
+"to specify
DavidSpickett resigned from this revision.
DavidSpickett added a comment.
I do cross build lldb a lot but never needed to set either of these, so I have
no opinion on this.
> clang/cmake/caches/CrossWinToARMLinux.cmake
Is not one of Linaro's, there's a buildbot for it
(https://lab.llvm.org/bui
tbaeder added subscribers: tuliom, tbaeder.
tbaeder added a comment.
CC @tstellar @tuliom since we use `GCC_INSTALL_PREFIX` at least in RHEL/CentOS.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158218/new/
https://reviews.llvm.org/D158218
___
smeenai added a comment.
Conceptually this seems like a great direction to go in. We should just leave
it up for a while so that anyone using these can comment on any potential
issues.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158218/new/
htt
MaskRay created this revision.
MaskRay added reviewers: DavidSpickett, phosek, smeenai, tra, tstellar.
Herald added subscribers: ekilmer, s.egerton, abidh, PkmX, atanasyan,
simoncook, fedor.sergeev, kristof.beyls, krytarowski, arichardson, sdardis,
emaste.
Herald added a project: All.
MaskRay req
12 matches
Mail list logo