[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

ddpagan added a comment. Is there a github PR associated with this? If yes, what is the PR? If not, one should be created that includes a fix for the teams loop/loop error issue. Please add me as a reviewer. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

ddpagan added a comment. Ok. Thanks for the clarification. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 ___ cfe-commits mailing list

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

koops added a comment. In D158266#4655433 , @ddpagan wrote: > Did anything change after the patch was reverted? I have not changed anything in the code yet. I am still investigating. The test where it is failing has nothing to do with my changes. I do

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

ddpagan added a comment. Did anything change after the patch was reverted? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 ___ cfe-commits mailing list

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

koops added a comment. Can someone please backout the changes done with this commit? It is resulting in build failures on debian. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

This revision was automatically updated to reflect the committed changes. Closed by commit rG85f6b2fac9a3: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region (authored by koops, committed by Sandeep Kosuri kosu...@pe28vega.us.cray.com). Changed prior to commit:

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 ___ cfe-commits mailing list

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

koops updated this revision to Diff 557877. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 Files: clang/include/clang/Basic/DiagnosticParseKinds.td clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

koops updated this revision to Diff 557876. koops added a comment. Removing multiple calls to Sema::checkNestingOfRegions() in Sema::ActOnOpenMPExecutableDirective() . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 Files:

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:6181-6190 + checkNestingOfRegions(*this, DSAStack, Kind, DirName, CancelRegion, +BindKind, StartLoc); Kind = OMPD_for; DSAStack->setCurrentDirective(OMPD_for);

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

koops added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:6181-6190 + checkNestingOfRegions(*this, DSAStack, Kind, DirName, CancelRegion, +BindKind, StartLoc); Kind = OMPD_for; DSAStack->setCurrentDirective(OMPD_for);

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:6181-6190 + checkNestingOfRegions(*this, DSAStack, Kind, DirName, CancelRegion, +BindKind, StartLoc); Kind = OMPD_for; DSAStack->setCurrentDirective(OMPD_for);

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

koops updated this revision to Diff 557639. koops added a comment. Avoiding executing "checkNestingOfRegions( )" multiple times. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 Files: clang/include/clang/Sema/Sema.h

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:6230 BindKind = BC->getBindKind(); + // First check CancelRegion which is then used in checkNestingOfRegions. Remove this new line Comment at:

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

koops updated this revision to Diff 557506. koops added a comment. Moving checks of Work Sharing Directive in mapLoopConstruct to checkNestingOfRegions(). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 Files:

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:6167-6183 + if (isOpenMPWorksharingDirective(ParentDirective) || + ParentDirective == OMPD_loop) { +Diag(StartLoc, diag::err_omp_prohibited_region) +<< true <<

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

koops updated this revision to Diff 557397. koops added a comment. Adding extra test cases to loop_bind_messages.cpp. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaOpenMP.cpp

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

ABataev added a comment. In D158266#4640416 , @koops wrote: > Can someone please review the changes that I uploaded last week? Still need to add extra tests to the nesting_of_regions.cpp test CHANGES SINCE LAST ACTION

[PATCH] D158266: [OpenMP] Patch for Support to loop bind clause : Checking Parent Region

koops added a comment. Can someone please review the changes that I uploaded last week? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158266/new/ https://reviews.llvm.org/D158266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org