[PATCH] D158409: [WebAssembly] Add multiple memories feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG86ed8cb8fabe: [WebAssembly] Add multiple memories feature (authored by ashleynh, committed by tlively). Changed prior to commit: https://reviews.l

[PATCH] D158409: [WebAssembly] Add multiple memories feature

ashleynh added inline comments. Comment at: clang/include/clang/Driver/Options.td:4583-4584 def mno_extended_const : Flag<["-"], "mno-extended-const">, Group; +def mmulti_memories : Flag<["-"], "mmulti-memories">, Group; +def mno_multi_memories : Flag<["-"], "mno-multi-memorie

[PATCH] D158409: [WebAssembly] Add multiple memories feature

tlively added inline comments. Comment at: clang/include/clang/Driver/Options.td:4583-4584 def mno_extended_const : Flag<["-"], "mno-extended-const">, Group; +def mmulti_memories : Flag<["-"], "mmulti-memories">, Group; +def mno_multi_memories : Flag<["-"], "mno-multi-memories

[PATCH] D158409: [WebAssembly] Add multiple memories feature

ashleynh updated this revision to Diff 552097. ashleynh added a comment. switching back to multiple memories for description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158409/new/ https://reviews.llvm.org/D158409 Files: clang/include/clang/Dr

[PATCH] D158409: [WebAssembly] Add multiple memories feature

aheejin added inline comments. Comment at: clang/include/clang/Driver/Options.td:4583-4584 def mno_extended_const : Flag<["-"], "mno-extended-const">, Group; +def mmulti_memories : Flag<["-"], "mmulti-memories">, Group; +def mno_multi_memories : Flag<["-"], "mno-multi-memories

[PATCH] D158409: [WebAssembly] Add multiple memories feature

ashleynh updated this revision to Diff 552096. ashleynh added a comment. removed - Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158409/new/ https://reviews.llvm.org/D158409 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Targets/

[PATCH] D158409: [WebAssembly] Add multiple memories feature

aheejin accepted this revision. aheejin added a comment. This revision is now accepted and ready to land. LGTM % nit and the name resolution (multimemory vs. multi-memory) Comment at: clang/include/clang/Driver/Options.td:4583-4584 def mno_extended_const : Flag<["-"], "mno-ext

[PATCH] D158409: [WebAssembly] Add multiple memories feature

ashleynh updated this revision to Diff 552088. ashleynh added a comment. Squashed into one commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158409/new/ https://reviews.llvm.org/D158409 Files: clang/include/clang/Driver/Options.td clang/lib

[PATCH] D158409: [WebAssembly] Add multiple memories feature

ashleynh updated this revision to Diff 552071. ashleynh added a comment. Addressing comments Renamed flag, test file, and added to wasm-features.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158409/new/ https://reviews.llvm.org/D158409 Files:

[PATCH] D158409: [WebAssembly] Add multiple memories feature

sbc100 added a comment. In D158409#4603829 , @tlively wrote: > The other file to update here is clang/test/Driver/wasm-features.c. It looks > like we haven't been as consistent about updating that one. Darn it, you beat be by 2 minutes. Repository:

[PATCH] D158409: [WebAssembly] Add multiple memories feature

sbc100 added inline comments. Comment at: clang/include/clang/Driver/Options.td:4583 def mno_extended_const : Flag<["-"], "mno-extended-const">, Group; +def mmulti_memories : Flag<["-"], "mmulti-memories">, Group; +def mno_multi_memories : Flag<["-"], "mno-multi-memories">, G

[PATCH] D158409: [WebAssembly] Add multiple memories feature

tlively added a comment. The other file to update here is clang/test/Driver/wasm-features.c. It looks like we haven't been as consistent about updating that one. Comment at: clang/include/clang/Driver/Options.td:4583-4584 def mno_extended_const : Flag<["-"], "mno-extended-con

[PATCH] D158409: [WebAssembly] Add multiple memories feature

ashleynh created this revision. ashleynh added reviewers: aheejin, dschuff, tlively. Herald added subscribers: pmatos, asb, sunfish, hiraditya, jgravelle-google. Herald added a project: All. ashleynh requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: ll