[PATCH] D158502: [clang][Interp] Actually consider ConstantExpr result

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG293ae0b4b45f: [clang][Interp] Actually consider ConstantExpr result (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D158502: [clang][Interp] Actually consider ConstantExpr result

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158502/new/ https://reviews.llvm.org/D158502 ___ cfe-commits mailing list

[PATCH] D158502: [clang][Interp] Actually consider ConstantExpr result

tbaeder updated this revision to Diff 556474. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158502/new/ https://reviews.llvm.org/D158502 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp Index: clang/lib/AST/Interp/ByteCodeExprGen.cpp =

[PATCH] D158502: [clang][Interp] Actually consider ConstantExpr result

tbaeder added a comment. In D158502#4616174 , @cor3ntin wrote: > FYI there are build failures. you probably need to rebase (visitAPValue does > not seem to actually exist) This depends on the `__builtin_offsetof()` patch. Repository: rG LLVM Github

[PATCH] D158502: [clang][Interp] Actually consider ConstantExpr result

cor3ntin added a comment. FYI there are build failures. you probably need to rebase (visitAPValue does not seem to actually exist) Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:767-772 + std::optional T = classify(E->getType()); + if (T && E->hasAPValueResult() && +

[PATCH] D158502: [clang][Interp] Actually consider ConstantExpr result

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:767-772 + std::optional T = classify(E->getType()); + if (T && E->hasAPValueResult() && + this->visitAPValue(E->getAPValueResult(), *T, E)) +return true; + return this->delegate(E->g

[PATCH] D158502: [clang][Interp] Actually consider ConstantExpr result

cor3ntin added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:767-772 + std::optional T = classify(E->getType()); + if (T && E->hasAPValueResult() && + this->visitAPValue(E->getAPValueResult(), *T, E)) +return true; + return this->delegate(E->

[PATCH] D158502: [clang][Interp] Actually consider ConstantExpr result

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Since we have visitAPValue now, we might as well use