[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi updated this revision to Diff 555074. victorkingi added a comment. Moved function implementations from llvm directory to clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158507/new/ https://reviews.llvm.org/D158507 Files: clang/in

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi updated this revision to Diff 552390. victorkingi added a comment. Removed mframe_pointer_eq update in Options.td, not required. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158507/new/ https://reviews.llvm.org/D158507 Files: clang/

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi updated this revision to Diff 552381. victorkingi added a comment. revert addition of m64 visibility in Options.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158507/new/ https://reviews.llvm.org/D158507 Files: clang/include/clang/

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi updated this revision to Diff 552375. victorkingi added a comment. Added m64 visibility to flang in Options.td Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158507/new/ https://reviews.llvm.org/D158507 Files: clang/include/clang/Driv

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi added inline comments. Comment at: clang/include/clang/Driver/Options.td:7236-7240 +def mframe_pointer_EQ : Joined<["-"], "mframe-pointer=">, + HelpText<"Specify which frame pointers to retain.">, Values<"all,non-leaf,none">, + NormalizedValuesScope<"CodeGenOptions

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi updated this revision to Diff 552330. victorkingi added a comment. Minimalized patch to only have update to Options.td as well as tests accompanying the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158507/new/ https://reviews.

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer 1/2

victorkingi added a comment. In D158507#4606498 , @awarzynski wrote: >> Temporary fix for unknown argument error '-fomit-frame-pointer' when running >> flang tests > > I don't follow - there's quite a lot going on here. More than the summary > suggests

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer

awarzynski added a comment. > Temporary fix for unknown argument error '-fomit-frame-pointer' when running > flang tests I don't follow - there's quite a lot going on here. More than the summary suggests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer

kiranchandramohan added a comment. For our immediate purpose, I think changing the visibility in the Driver to include `flang` is sufficient. After that, we can spend time implementing this properly by refactoring the code to llvm. Comment at: llvm/include/llvm/Frontend/Drive

[PATCH] D158507: [Flang][Driver] Add support for fomit-frame-pointer

victorkingi created this revision. Herald added subscribers: abrachet, phosek, s.egerton, simoncook, asb, fedor.sergeev, dschuff. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. victorkingi requested review of this revision. Herald added