This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0661533e4168: [AMDGPU] Prepend --no-undefined option for
linker instead of append (authored by lamb-j).
Repository:
rG LLVM Github Monorepo
CHANG
yaxunl accepted this revision.
yaxunl added a comment.
LGTM. Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158582/new/
https://reviews.llvm.org/D158582
___
cfe-commits mailing list
cfe-commits@li
lamb-j updated this revision to Diff 552803.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158582/new/
https://reviews.llvm.org/D158582
Files:
clang/lib/Driver/ToolChains/AMDGPU.cpp
clang/test/Driver/amdgpu-toolchain-opencl.cl
clang/test/Drive
yaxunl added inline comments.
Comment at: clang/test/Driver/amdgpu-toolchain-opencl.cl:34
+// RUN: %clang -### --target=amdgcn-amd-amdhsa-opencl -Xlinker
--unresolved-symbols=ignore-all -x cl -mcpu=fiji -nogpulib %s 2>&1 | FileCheck
-check-prefix=CHK-LINK_UR %s
+// CHK-LINK_UR:
lamb-j retitled this revision from "[AMDGPU] Respect unresolved symbol option
if forwarded to linker" to "[AMDGPU] Prepend --no-undefined option for linker
instead of append".
lamb-j updated this revision to Diff 552777.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://