[PATCH] D158591: Add support of Windows Trace Logging macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe6d305e64fd3: Add support of Windows Trace Logging macros (authored by RIscRIpt, committed by cor3ntin). Changed prior to commit:

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt added a comment. Looks good. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D158591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin added a comment. @RIscRIpt I added release notes, let me know if you are happy with everything before i land Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D158591

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin updated this revision to Diff 555712. cor3ntin added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D158591 Files: clang/docs/ReleaseNotes.rst

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt added a comment. In D158591#4636814 , @cor3ntin wrote: > Hum. before I do > > - I think the commit message could be more explicit as to what the patch does > ("Add support of Windows Trace Logging macros" is a bit vague) > - Do we need a

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin added a comment. Hum. before I do - I think the commit message could be more explicit as to what the patch does ("Add support of Windows Trace Logging macros" is a bit vague) - Do we need a release note ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin added a comment. Oh! I should have asked sooner. Will do! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D158591 ___ cfe-commits mailing list

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt added a comment. @cor3ntin, thanks for asking. No, I do not have access. Please merge. Commits should have correct email and name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D158591

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin added a comment. @RIscRIpt Do you need further help on this patch? You have commit access, right? (I'm trying to make sure things don't fall through the cracks as we move to github) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt updated this revision to Diff 553444. RIscRIpt added a comment. Rebased onto main, fixed commit messages, fixed formatting, re-run lit for clang/test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt added a comment. In D158591#4616728 , @RIscRIpt wrote: > And it seems that `BasePtr` points to a different object, not the one which > corresponds to StringLiteral (at step 2). If I understand everything correctly, then in

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. I'm happy punting the new interpreter to a subsequent PR, maybe there are unresolved issues with string literals? Anyway, we don't have to scope creep further, LGTM Thanks for working on

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt added a comment. Regarding new interpreter. It takes more time and effort than I expected. Here's what I found: 1. Assertion in ByteCodeExprGen::VisitPredefinedExpr

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt updated this revision to Diff 553437. RIscRIpt marked 2 inline comments as done. RIscRIpt added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D158591 Files:

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin added a subscriber: tbaeder. cor3ntin added a comment. Looks mostly good to me, thanks! In D158591#4613868 , @RIscRIpt wrote: > The current implementation of `getPredefinedExprDeclContext` could be easily > moved to a static function inside

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt added a comment. The current implementation of `getPredefinedExprDeclContext` could be easily moved to a static function inside `clang/lib/Sema/SemaExpr.cpp` as it depends only on `Sema::CurContext` WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt added a comment. I missed this comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/ https://reviews.llvm.org/D158591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt updated this revision to Diff 553123. RIscRIpt marked an inline comment as done. RIscRIpt added a comment. Use isa<...> in getPredefinedExprDeclContext Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt updated this revision to Diff 553122. RIscRIpt marked an inline comment as done. RIscRIpt added a comment. Rebase onto main, address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158591/new/

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1495-1499 + DeclContext *DC = CurContext; + while (DC && !isa(DC) && !isa(DC) && + !isa(DC) && !isa(DC)) +DC = DC->getParent(); + return dyn_cast_or_null(DC); RIscRIpt wrote: >

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt marked 2 inline comments as done. RIscRIpt added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1495-1499 + DeclContext *DC = CurContext; + while (DC && !isa(DC) && !isa(DC) && + !isa(DC) && !isa(DC)) +DC = DC->getParent(); + return

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1495-1499 + DeclContext *DC = CurContext; + while (DC && !isa(DC) && !isa(DC) && + !isa(DC) && !isa(DC)) +DC = DC->getParent(); + return dyn_cast_or_null(DC); RIscRIpt wrote: >

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt marked an inline comment as done. RIscRIpt added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1495-1499 + DeclContext *DC = CurContext; + while (DC && !isa(DC) && !isa(DC) && + !isa(DC) && !isa(DC)) +DC = DC->getParent(); + return

[PATCH] D158591: Add support of Windows Trace Logging macros

cor3ntin added inline comments. Comment at: clang/lib/Sema/Sema.cpp:1495-1499 + DeclContext *DC = CurContext; + while (DC && !isa(DC) && !isa(DC) && + !isa(DC) && !isa(DC)) +DC = DC->getParent(); + return dyn_cast_or_null(DC); I think this is

[PATCH] D158591: Add support of Windows Trace Logging macros

RIscRIpt created this revision. Herald added a subscriber: pengfei. Herald added a project: All. RIscRIpt requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Consider the following code: #include #include #include #include