[PATCH] D158612: [flang][driver] Ensure negative flags have the same visibility as positive

2023-08-29 Thread Tom Eccles via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG125abbdc9767: [flang][driver] Ensure negative flags have the same visibility as positive (authored by tblah). Changed prior to commit: https://rev

[PATCH] D158612: [flang][driver] Ensure negative flags have the same visibility as positive

2023-08-23 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added inline comments. Comment at: flang/test/Driver/fintegrated-as.f90:15 +! +! Without `-fno-integrated-as` (default) / With `-fintegrated-as` +!-

[PATCH] D158612: [flang][driver] Ensure negative flags have the same visibility as positive

2023-08-23 Thread Tom Eccles via Phabricator via cfe-commits
tblah updated this revision to Diff 552723. tblah added a comment. Thanks for taking a look. Changes: add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158612/new/ https://reviews.llvm.org/D158612 Files: clang/include/clang/Driver/Options.

[PATCH] D158612: [flang][driver] Ensure negative flags have the same visibility as positive

2023-08-23 Thread Andrzej Warzynski via Phabricator via cfe-commits
awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. LGTM, ta! Comment at: clang/include/clang/Driver/Options.td:5314 NegFlag, - PosFlag, + PosFlag, BothFlags<[], [ClangOption], " the integrated assembler">>; --

[PATCH] D158612: [flang][driver] Ensure negative flags have the same visibility as positive

2023-08-23 Thread Tom Eccles via Phabricator via cfe-commits
tblah created this revision. tblah added reviewers: awarzynski, bogner, MaskRay. Herald added a reviewer: sscalpone. Herald added projects: Flang, All. tblah requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. https://reviews.llvm.org