This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6824d156d5dd: [Clang] Fix a crash when an invalid immediate
function call appears in a cast (authored by cor3ntin).
Repository:
rG LLVM Github Mon
cor3ntin updated this revision to Diff 553385.
cor3ntin added a comment.
Rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158733/new/
https://reviews.llvm.org/D158733
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Sema/SemaExpr.cpp
clang/t
cor3ntin updated this revision to Diff 553381.
cor3ntin added a comment.
Address comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158733/new/
https://reviews.llvm.org/D158733
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Sema/SemaExpr.cpp
shafik added inline comments.
Comment at: clang/test/SemaCXX/cxx2a-consteval.cpp:1120
+
+void k() { (int)h{nullptr}; }
+// expected-error@-1 {{call to consteval function 'GH64949::h::h' is not a
constant expression}}
Another variety maybe worthing adding a test
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
1 nit that the build bots caught, else I'm happy.
Comment at: clang/lib/Sema/SemaExpr.cpp:18364
+
+assert(FD && FD->isImmediateFunction &&
+ "could not
cor3ntin updated this revision to Diff 553109.
cor3ntin added a comment.
Remove accidentyally commited change
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158733/new/
https://reviews.llvm.org/D158733
Files:
clang/docs/ReleaseNotes.rst
clang/l
cor3ntin created this revision.
Herald added a project: All.
cor3ntin requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.
Fixes #64949
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D158733
Files:
clang/d
