This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG282da837565f: [XCOFF][AIX] Issue an error when specifying an
alias for a common symbol (authored by stephenpeckham).
Changed prior to commit:
DiggerLin accepted this revision.
DiggerLin added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158739/new/
https://reviews.llvm.org/D158739
___
cfe-commits mailing list
stephenpeckham updated this revision to Diff 554299.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158739/new/
https://reviews.llvm.org/D158739
Files:
clang/include/clang/Basic/DiagnosticFrontendKinds.td
clang/lib/CodeGen/CodeGenModule.cpp
clang/test/CodeGen/aix-common.c
hubert.reinterpretcast added a comment.
Aside from the comments Digger has made, I have no additional concerns about
this patch. It is an improvement (although there are adjacent cases that need
further handling).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
DiggerLin added inline comments.
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:566
static bool checkAliasedGlobal(
-DiagnosticsEngine , SourceLocation Location, bool IsIFunc,
-const llvm::GlobalValue *Alias, const llvm::GlobalValue *,
+ASTContext ,
stephenpeckham created this revision.
stephenpeckham added reviewers: hubert.reinterpretcast, DiggerLin, jhenderson.
Herald added subscribers: jeroen.dobbelaere, kbarton, hiraditya, nemanjai.
Herald added a project: All.
stephenpeckham requested review of this revision.
Herald added projects:
