This revision was automatically updated to reflect the committed changes.
Closed by commit rG4294bca5e4f6: [clang-tidy] Add exit code support to
clang-tidy-diff.py (authored by PiotrZSL).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158929/new/
htt
carlosgalvezp accepted this revision.
carlosgalvezp added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158929/new/
https://reviews.llvm.org/D158929
FlashSheridan added a comment.
Thank you kindly, this is looking very good on our recent changes in my manual
usage. (It will take some more work before I can run it in our GitHub Action,
which I’m looking forward to.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https:/
PiotrZSL updated this revision to Diff 554028.
PiotrZSL marked 2 inline comments as done.
PiotrZSL added a comment.
Fix some Pylint issues.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158929/new/
https://reviews.llvm.org/D158929
Files:
clang-t
FlashSheridan added a comment.
A couple of low-priority suggestions from Pylint 3 at 326 and 95:
Comment at: clang-tools-extra/clang-tidy/tool/clang-tidy-diff.py:95
-def start_workers(max_tasks, tidy_caller, task_queue, lock, timeout):
+def start_workers(max_tasks, tidy_calle
FlashSheridan added a comment.
Thank you, looks promising and I will test it on Monday.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158929/new/
https://reviews.llvm.org/D158929
___
cfe-commits mailing
PiotrZSL created this revision.
PiotrZSL added reviewers: njames93, carlosgalvezp.
Herald added a subscriber: xazax.hun.
Herald added a project: All.
PiotrZSL requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
Modify script to fail
