[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad added a comment. In D159054#4638511 , @probinson wrote: > The main thing to worry about, clearly, is what happens as the change > percolates downstream and into distros. But you probably know more about that > than I do anyhow. :) Yes, that is

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

probinson added a comment. @MaskRay thanks for the info! In D159054#4638322 , @brad wrote: > I was going to hold this over for a bit longer. 2 weeks and if no one says > anything then go ahead? The main thing to worry about, clearly, is what happens

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad added a comment. I was going to hold this over for a bit longer. 2 weeks and if no one says anything then go ahead? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159054/new/ https://reviews.llvm.org/D159054

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

MaskRay added a comment. In D159054#4628278 , @probinson wrote: > In D159054#4626772 , @brad wrote: > >> Just FYI I am not in a rush to commit this. I am posting this more so as a >> means of prodding for

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

probinson added a comment. In D159054#4626772 , @brad wrote: > Just FYI I am not in a rush to commit this. I am posting this more so as a > means of prodding for discussion of the feature. So far nobody has popped up to say they want it. @MaskRay I

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad updated this revision to Diff 554567. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159054/new/ https://reviews.llvm.org/D159054 Files: clang/CMakeLists.txt clang/include/clang/Config/config.h.cmake clang/lib/Driver/ToolChains/Darwin.cpp

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad added a comment. Just FYI I am not in a rush to commit this. I am posting this more so as a means of prodding for discussion of the feature. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159054/new/ https://reviews.llvm.org/D159054

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad updated this revision to Diff 554156. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159054/new/ https://reviews.llvm.org/D159054 Files: clang/CMakeLists.txt clang/include/clang/Config/config.h.cmake clang/lib/Driver/ToolChains/Darwin.cpp

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Technically there is some risk but I think the blast radius, if present, is extremely small. `C_INCLUDE_DIRS` is not recognized by GCC. If I use

[PATCH] D159054: [Driver] Removal of C_INCLUDE_DIRS feature

brad created this revision. brad added reviewers: MaskRay, tstellar, probinson. brad added a project: clang. Herald added subscribers: pmatos, asb, abrachet, jgravelle-google, sbc100, dschuff, emaste. Herald added a project: All. brad requested review of this revision. Herald added a subscriber: