jlebar updated this revision to Diff 44308.
jlebar retitled this revision from "Move ownership of Action objects into
Compilation.
" to "Move ownership of Action objects into Compilation.".
jlebar added a comment.
Clear both Actions and OwningActions in
Compilation::initCompilationForDiagnostics
jlebar added a comment.
Changed to move ownership into Compilation, as discussed earlier today. Please
have a look.
http://reviews.llvm.org/D15911
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
tra added inline comments.
Comment at: include/clang/Driver/Action.h:36
@@ -35,1 +35,3 @@
+///
+/// Actions are usually owned by a Compilation.
class Action {
There's no API to pass ownership to Compilation explicitly, so the only way for
an Action to be owned b
On Fri, Jan 8, 2016 at 10:08 AM, Artem Belevich via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> tra added inline comments.
>
>
> Comment at: include/clang/Driver/Action.h:36
> @@ -35,1 +35,3 @@
> +///
> +/// Actions are usually owned by a Compilation.
> class Action {
> --
On Fri, Jan 8, 2016 at 10:55 AM, David Blaikie wrote:
>
>
> On Fri, Jan 8, 2016 at 10:08 AM, Artem Belevich via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> tra added inline comments.
>>
>>
>> Comment at: include/clang/Driver/Action.h:36
>> @@ -35,1 +35,3 @@
>> +///
>>
dblaikie added inline comments.
Comment at: include/clang/Driver/Compilation.h:54
@@ +53,3 @@
+ /// to consumers; it's here just to manage ownership.
+ std::vector> OwningActions;
+
Seems like this name isn't quite right ("OwningActions" sounds like "these are
jlebar added inline comments.
Comment at: include/clang/Driver/Action.h:36
@@ -35,1 +35,3 @@
+///
+/// Actions are usually owned by a Compilation.
class Action {
tra wrote:
> There's no API to pass ownership to Compilation explicitly, so the only way
> for an Ac
jlebar updated this revision to Diff 44379.
jlebar marked 4 inline comments as done.
jlebar added a comment.
Address tra and dblaikie's review comments.
http://reviews.llvm.org/D15911
Files:
include/clang/Driver/Action.h
include/clang/Driver/Compilation.h
include/clang/Driver/Driver.h
l
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for doing this :)
-eric
http://reviews.llvm.org/D15911
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
This revision was automatically updated to reflect the committed changes.
Closed by commit rL257407: Move ownership of Action objects into Compilation.
(authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D15911?vs=44379&id=44566#toc
Repository:
rL LLVM
http://reviews.llvm
10 matches
Mail list logo