danix800 added inline comments.
Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:169
+ else
+Unused.push_back();
+ continue;
sammccall wrote:
> If we want this policy, it should be provided at the include-cleaner library
>
danix800 added inline comments.
Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:227
+ << Inc.SymRef.Target.name();
+ if (!AlreadyInserted.contains(Inc.Missing.resolvedPath())) {
+DB << FixItHint::CreateInsertion(
sammccall added a comment.
Thanks! @kadircet should make the call on these features (they look good to
me), I have some implementation notes.
This is making two independent changes, one is a policy change that should be
applied to the include-cleaner library, and one is a bugfix to the
danix800 created this revision.
danix800 added reviewers: VitaNuo, kadircet, sammccall.
danix800 added a project: clang-tools-extra.
Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun.
Herald added a reviewer: njames93.
Herald added a project: All.
danix800 requested review of this
