Re: [PATCH] D15936: Update code in buildCudaActions and BuildActions to latest idiom.

2016-01-08 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL257190: Update code in buildCudaActions and BuildActions to latest idiom. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D15936?vs=44158&id=44341#toc Repository: rL LLVM http

Re: [PATCH] D15936: Update code in buildCudaActions and BuildActions to latest idiom.

2016-01-06 Thread Justin Lebar via cfe-commits
jlebar marked an inline comment as done. jlebar added a comment. http://reviews.llvm.org/D15936 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15936: Update code in buildCudaActions and BuildActions to latest idiom.

2016-01-06 Thread Justin Lebar via cfe-commits
jlebar updated this revision to Diff 44158. jlebar added a comment. Address tra's review comments. http://reviews.llvm.org/D15936 Files: lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp === --- lib/Driver/Driver.cpp +++ lib/Dr

Re: [PATCH] D15936: Update code in buildCudaActions and BuildActions to latest idiom.

2016-01-06 Thread Artem Belevich via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM Comment at: lib/Driver/Driver.cpp:1300 @@ -1299,5 +1299,3 @@ for (Arg *A : Args) { -if (A->getOption().matches(options::OPT_cuda_gpu_arch_EQ)) { - A->claim(); -

Re: [PATCH] D15936: Update code in buildCudaActions and BuildActions to latest idiom.

2016-01-06 Thread Justin Lebar via cfe-commits
jlebar updated this revision to Diff 44155. jlebar added a comment. Fix rebase conflict. http://reviews.llvm.org/D15936 Files: lib/Driver/Driver.cpp Index: lib/Driver/Driver.cpp === --- lib/Driver/Driver.cpp +++ lib/Driver/Drive

Re: [PATCH] D15936: Update code in buildCudaActions and BuildActions to latest idiom.

2016-01-06 Thread Justin Lebar via cfe-commits
jlebar updated this revision to Diff 44154. jlebar added a dependency: D15911: Switch Action and ActionList over to using std::shared_ptr.. jlebar added a comment. Rebasing onto http://reviews.llvm.org/D15911. Depends on http://reviews.llvm.org/D15911. http://reviews.llvm.org/D15936 Files: