[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

This revision was automatically updated to reflect the committed changes. Closed by commit rGd03a7f15f019: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free (authored by ivanmurashko). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

ivanmurashko added a comment. In D159363#4636581 , @kadircet wrote: > thanks, the fix LGTM as well. > > but i wonder how this surfaces, to make sure we're taking necessary > precautions in the future. we definitely have a dangling reference, which > isn

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

kadircet added a comment. thanks, the fix LGTM as well. but i wonder how this surfaces, to make sure we're taking necessary precautions in the future. we definitely have a dangling reference, which isn't great. but it's surprising that we access diags consumer during indexing. I assume it's abo

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

kadircet added a comment. thanks, the fix LGTM as well. but i wonder how this surfaces, to make sure we're taking necessary precautions in the future. we definitely have a dangling reference, which isn't great. but it's surprising that we access diags consumer during indexing. I assume it's abo

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

ivanmurashko added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:709 Ctx->setStatCache(Result->StatCache); + // We have to setup DiagnosticConsumer that will be alife + // while preamble callback is executed sammccall wrote:

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

ivanmurashko updated this revision to Diff 555441. ivanmurashko marked an inline comment as done. ivanmurashko added a comment. @sammccall's comment was addressed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159363/new/ https://reviews.llvm.org/D1

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:610-619 StoreDiags PreambleDiagnostics; PreambleDiagnostics.setDiagCallback( [&ASTListeners](const clang::Diagnostic &D, clangd::Diag &Diag) { llvm::for_each(ASTListeners,

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Nice catch! Comment at: clang-tools-extra/clangd/Preamble.cpp:709 Ctx->setStatCache(Result->StatCache); + // We have to setup DiagnosticConsumer that will b

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

ivanmurashko added inline comments. Comment at: clang-tools-extra/clangd/Preamble.cpp:610-619 StoreDiags PreambleDiagnostics; PreambleDiagnostics.setDiagCallback( [&ASTListeners](const clang::Diagnostic &D, clangd::Diag &Diag) { llvm::for_each(ASTListeners,

[PATCH] D159363: [clangd] SIGSEGV at clangd: DiagnosticConsumer Is Used After Free

ivanmurashko created this revision. ivanmurashko added reviewers: kadircet, sammccall. ivanmurashko added projects: clang, clang-tools-extra. Herald added a subscriber: arphaman. Herald added a project: All. ivanmurashko requested review of this revision. Herald added subscribers: cfe-commits, Mask