This revision was automatically updated to reflect the committed changes.
Closed by commit rG7a73da4c85a1: [clang-tidy] Add support for optional
parameters in config. (authored by felix642, committed by PiotrZSL).
Changed prior to commit:
https://reviews.llvm.org/D159436?vs=557546=557652#toc
felix642 updated this revision to Diff 557546.
felix642 added a comment.
Wrong check name
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159436/new/
https://reviews.llvm.org/D159436
Files:
clang-tools-extra/clang-tidy/ClangTidyCheck.h
felix642 updated this revision to Diff 557545.
felix642 marked 3 inline comments as done.
felix642 added a comment.
Updated documentation
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159436/new/
https://reviews.llvm.org/D159436
Files:
PiotrZSL accepted this revision.
PiotrZSL added a comment.
This revision is now accepted and ready to land.
Except few nits in documentation looks fine. Probably one day in future we can
add same for bools.
Make sure that documentation of impacted checks is correct, so it says that
argument is
felix642 added a comment.
ping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159436/new/
https://reviews.llvm.org/D159436
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
felix642 updated this revision to Diff 556334.
felix642 added a comment.
Forgot to update a comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159436/new/
https://reviews.llvm.org/D159436
Files:
clang-tools-extra/clang-tidy/ClangTidyCheck.h
felix642 added a comment.
Hi @PiotrZSL and @carlosgalvezp, I have updated my PR based on your comments.
Let me know what you think.
What if:
"MinimumLength" is a boolean.
It's default value (if not specified) is True.
And a user wants to set it as "False" here
Wouldn't that
felix642 updated this revision to Diff 556333.
felix642 added a comment.
Moved to a new method, changed tests, changed documentation
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159436/new/
https://reviews.llvm.org/D159436
Files:
felix642 updated this revision to Diff 556331.
felix642 added a comment.
Removed false option
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159436/new/
https://reviews.llvm.org/D159436
Files:
clang-tools-extra/clang-tidy/ClangTidyCheck.h
felix642 updated this revision to Diff 556328.
felix642 added a comment.
Updated documentation
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159436/new/
https://reviews.llvm.org/D159436
Files:
clang-tools-extra/clang-tidy/ClangTidyCheck.h
felix642 updated this revision to Diff 556326.
felix642 added a comment.
Updated Differential to truly support optional parameters
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159436/new/
https://reviews.llvm.org/D159436
Files:
PiotrZSL added inline comments.
Comment at: clang-tools-extra/clang-tidy/ClangTidyCheck.h:196-198
+if (Value == "" || Value == "none" || Value == "null" ||
+ Value == "false" || (std::is_unsigned_v && Value == "-1"))
+ return std::nullopt;
carlosgalvezp added inline comments.
Comment at:
clang-tools-extra/test/clang-tidy/infrastructure/optional-parameter.cpp:18
+// RUN: -config='{CheckOptions: { \
+// RUN: bugprone-easily-swappable-parameters.MinimumLength: "false", \
+// RUN: }}' --
What
carlosgalvezp added a comment.
Thanks for the patch! I must admit I don't fully understand what problem it
solves, i.e. parameters are already optional today (one just simply doesn't
specify them in the config file). Why would we want to explicitly spell out
parameters with some default value
felix642 updated this revision to Diff 555789.
felix642 added a comment.
Reworded release notes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159436/new/
https://reviews.llvm.org/D159436
Files:
clang-tools-extra/clang-tidy/ClangTidyCheck.h
felix642 updated this revision to Diff 555788.
felix642 added a comment.
Added entry to release notes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159436/new/
https://reviews.llvm.org/D159436
Files:
felix642 created this revision.
Herald added subscribers: PiotrZSL, xazax.hun.
Herald added a reviewer: njames93.
Herald added a project: All.
felix642 requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
If a parameter value is
17 matches
Mail list logo
