cor3ntin added a comment.
@to268 as discussed, i landed the change on your behalf. Thanks for the patch!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159522/new/
https://reviews.llvm.org/D159522
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rG624c13057874: [Clang][C] Fixed a bug where we reject an
_Atomic qualified integer in a switch… (authored by to268, committed by
cor3ntin).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
to268 updated this revision to Diff 556892.
to268 marked an inline comment as done.
to268 added a comment.
I have fixed the ReleaseNote formatting error.
Please land this patch on my behalf "Guillot Tony "
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM (with a tiny nit with the formatting in the release notes), thank you for
the fix!
Comment at: clang/docs/ReleaseNotes.rst:223
(`#64836
to268 updated this revision to Diff 556871.
to268 marked an inline comment as done.
to268 added a comment.
Added recommendation by @aaron.ballman
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159522/new/
https://reviews.llvm.org/D159522
Files:
to268 updated this revision to Diff 556868.
to268 added a comment.
I have added the missing ReleaseNote.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159522/new/
https://reviews.llvm.org/D159522
Files:
clang/docs/ReleaseNotes.rst
aaron.ballman added a comment.
Thank you for working on this! You should also add a release note for the fix.
Comment at: clang/lib/Sema/SemaOverload.cpp:6306-6310
+ ExprResult Converted = DefaultLvalueConversion(From);
+ QualType T = Converted.isUsable() ?
to268 created this revision.
to268 added a reviewer: aaron.ballman.
to268 added a project: clang.
Herald added a project: All.
to268 requested review of this revision.
Herald added a subscriber: cfe-commits.
We are currently rejecting an _Atomic qualified integer in a switch statment.
This fixes
