Re: [PATCH] D16041: Change vfs::FileSystem to be managed with std::shared_ptr

2016-01-11 Thread Owen Anderson via cfe-commits
> On Jan 11, 2016, at 2:13 PM, Benjamin Kramer wrote: > > On Mon, Jan 11, 2016 at 8:08 PM, Owen Anderson > wrote: >> >>> On Jan 11, 2016, at 8:25 AM, David Blaikie wrote: >>> >>> >>> >>> On Sun, Jan 10, 2016 at 11:42 PM, Owen Anderson via cfe-commits >>> wrote: >

Re: [PATCH] D16041: Change vfs::FileSystem to be managed with std::shared_ptr

2016-01-11 Thread Benjamin Kramer via cfe-commits
On Mon, Jan 11, 2016 at 8:08 PM, Owen Anderson wrote: > >> On Jan 11, 2016, at 8:25 AM, David Blaikie wrote: >> >> >> >> On Sun, Jan 10, 2016 at 11:42 PM, Owen Anderson via cfe-commits >> wrote: >> resistor created this revision. >> resistor added reviewers: chandlerc, bkramer, klimek. >> resis

Re: [PATCH] D16041: Change vfs::FileSystem to be managed with std::shared_ptr

2016-01-11 Thread Owen Anderson via cfe-commits
> On Jan 11, 2016, at 8:25 AM, David Blaikie wrote: > > > > On Sun, Jan 10, 2016 at 11:42 PM, Owen Anderson via cfe-commits > wrote: > resistor created this revision. > resistor added reviewers: chandlerc, bkramer, klimek. > resistor added a subscriber: cfe-commits. > resistor set the reposi

Re: [PATCH] D16041: Change vfs::FileSystem to be managed with std::shared_ptr

2016-01-11 Thread David Blaikie via cfe-commits
On Sun, Jan 10, 2016 at 11:42 PM, Owen Anderson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > resistor created this revision. > resistor added reviewers: chandlerc, bkramer, klimek. > resistor added a subscriber: cfe-commits. > resistor set the repository for this revision to rL LLVM. > H

[PATCH] D16041: Change vfs::FileSystem to be managed with std::shared_ptr

2016-01-10 Thread Owen Anderson via cfe-commits
resistor created this revision. resistor added reviewers: chandlerc, bkramer, klimek. resistor added a subscriber: cfe-commits. resistor set the repository for this revision to rL LLVM. Herald added a subscriber: klimek. Managing it with IntrusiveRefCntPtr caused the virtual destructor not to be