Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

This revision was automatically updated to reflect the committed changes. Closed by commit rL257341: [clang-format] Fix comment aligning when there are changes within the comment (authored by d0k). Changed prior to commit: http://reviews.llvm.org/D16058?vs=44513&id=44517#toc Repository: rL L

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

klimek accepted this revision. klimek added a reviewer: klimek. klimek added a comment. lg Comment at: lib/Format/WhitespaceManager.h:113 @@ -113,1 +112,3 @@ + bool ContinuesPPDirective, bool IsStartOfDeclName, + bool IsInsideTrailingCommentToken);

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

bkramer updated this revision to Diff 44513. bkramer added a comment. - Moved newline check into replaceWhitespaceInToken - Removed duplicated TokenLength computation http://reviews.llvm.org/D16058 Files: lib/Format/WhitespaceManager.cpp lib/Format/WhitespaceManager.h unittests/Format/For

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. I think this looks good, but I'd also like Manuel to take a look. http://reviews.llvm.org/D16058 ___ cfe-commits mailing list cfe-commits@lists

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

bkramer updated this revision to Diff 44508. bkramer added a comment. - Renamed flag to IsInsideToken and enabled it for all in-token replacements. - TokenLength now gets updated to contain all changes on the same line if they're in the same token. http://reviews.llvm.org/D16058 Files: lib/F

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

djasper added inline comments. Comment at: lib/Format/WhitespaceManager.h:145 @@ +144,3 @@ +// comment. +bool IsTrailingCommentContinuation; + klimek wrote: > djasper wrote: > > I find the term "continuation" a bit confusing here. How about something > >

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

bkramer updated this revision to Diff 44472. bkramer added a comment. Why not both? http://reviews.llvm.org/D16058 Files: lib/Format/WhitespaceManager.cpp lib/Format/WhitespaceManager.h unittests/Format/FormatTest.cpp Index: unittests/Format/FormatTest.cpp ===

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

klimek added inline comments. Comment at: lib/Format/WhitespaceManager.h:145 @@ +144,3 @@ +// comment. +bool IsTrailingCommentContinuation; + djasper wrote: > I find the term "continuation" a bit confusing here. How about something like > "IsInsideToken"?

Re: [PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

djasper added inline comments. Comment at: lib/Format/WhitespaceManager.h:145 @@ +144,3 @@ +// comment. +bool IsTrailingCommentContinuation; + I find the term "continuation" a bit confusing here. How about something like "IsInsideToken"? http://reviews.

[PATCH] D16058: [clang-format] Fix comment aligning when there are changes within the comment

bkramer created this revision. bkramer added a reviewer: djasper. bkramer added a subscriber: cfe-commits. Herald added a subscriber: klimek. As soon as a comment had whitespace changes inside of the token, we couldn't identify the whole comment as a trailing comment anymore and alignment stopped