[PATCH] D16307: [CUDA] Handle -O options (more) correctly.

2016-01-18 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: jhen, echristo, cfe-commits. Previously we'd crash the driver if you passed -O0. Now we try to handle all of clang's various optimization flags in a sane way. http://reviews.llvm.org/D16307 Files: lib/Driver

Re: [PATCH] D16307: [CUDA] Handle -O options (more) correctly.

2016-01-18 Thread Eric Christopher via cfe-commits
At a quick glance Os and Oz should probably map to O2. On Mon, Jan 18, 2016, 4:19 PM Justin Lebar wrote: > jlebar created this revision. > jlebar added a reviewer: tra. > jlebar added subscribers: jhen, echristo, cfe-commits. > > Previously we'd crash the driver if you passed -O0. Now we try to

Re: [PATCH] D16307: [CUDA] Handle -O options (more) correctly.

2016-01-18 Thread Justin Lebar via cfe-commits
jlebar updated this revision to Diff 45222. jlebar added a comment. Map -Os, -Oz to -O2, rather than -O3. http://reviews.llvm.org/D16307 Files: lib/Driver/Tools.cpp test/Driver/cuda-external-tools.cu Index: test/Driver/cuda-external-tools.cu

Re: [PATCH] D16307: [CUDA] Handle -O options (more) correctly.

2016-01-18 Thread Justin Lebar via cfe-commits
jlebar updated this revision to Diff 45223. jlebar added a comment. Update comment http://reviews.llvm.org/D16307 Files: lib/Driver/Tools.cpp test/Driver/cuda-external-tools.cu Index: test/Driver/cuda-external-tools.cu === ---

Re: [PATCH] D16307: [CUDA] Handle -O options (more) correctly.

2016-01-19 Thread Artem Belevich via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D16307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16307: [CUDA] Handle -O options (more) correctly.

2016-01-19 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL258174: [CUDA] Handle -O options (more) correctly. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D16307?vs=45223&id=45290#toc Repository: rL LLVM http://reviews.llvm.org/D16