[PATCH] D16331: [CUDA] Bail, rather than crash, on va_arg in device code.

2016-01-19 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: cfe-commits, jhen, echristo. http://reviews.llvm.org/D16331 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp test/SemaCUDA/vararg.cu Index: test/SemaCUDA/vararg.cu =

Re: [PATCH] D16331: [CUDA] Bail, rather than crash, on va_arg in device code.

2016-01-19 Thread Justin Lebar via cfe-commits
jlebar updated this revision to Diff 45305. jlebar added a comment. Rename test file. http://reviews.llvm.org/D16331 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaExpr.cpp test/SemaCUDA/va-arg.cu Index: test/SemaCUDA/va-arg.cu

Re: [PATCH] D16331: [CUDA] Bail, rather than crash, on va_arg in device code.

2016-01-19 Thread Artem Belevich via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. Small nit. LGTM otherwise. Comment at: lib/Sema/SemaExpr.cpp:11732 @@ +11731,3 @@ + // CUDA device code does not support varargs. + if (getLangOpts().CUDAIsDevice) { +if (cons

Re: [PATCH] D16331: [CUDA] Bail, rather than crash, on va_arg in device code.

2016-01-19 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. jlebar marked 2 inline comments as done. Closed by commit rL258264: [CUDA] Bail, rather than crash, on va_arg in device code. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D16331?vs=45305&id=45325

Re: [PATCH] D16331: [CUDA] Bail, rather than crash, on va_arg in device code.

2016-01-19 Thread Justin Lebar via cfe-commits
jlebar added a comment. Fixed and submitted. Repository: rL LLVM http://reviews.llvm.org/D16331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits