This revision was automatically updated to reflect the committed changes.
Closed by commit rL258734: [CUDA] Don't generate aliases for static extern "C"
functions. (authored by jlebar).
Changed prior to commit:
http://reviews.llvm.org/D16501?vs=45781&id=45919#toc
Repository:
rL LLVM
http://
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
OK. If someone attempts to rely on this feature in CUDA it will be obviously
broken due to the missing C-style mangled name. We can deal with it then.
http://reviews.llvm.org/D16501
jlebar added a comment.
In http://reviews.llvm.org/D16501#335225, @tra wrote:
> Failing silently is not a good idea. At the very least there should produce
> an error.
> The right thing to do here, IMO, would be to generate a stub with alias name
> that just jumps to or calls aliasee.
Discus
tra added a comment.
Failing silently is not a good idea. At the very least there should produce an
error.
The right thing to do here, IMO, would be to generate a stub with alias name
that just jumps to or calls aliasee.
http://reviews.llvm.org/D16501
___
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: echristo, jhen, cfe-commits.
These aliases are done to support inline asm, but there's nothing we can
do: NVPTX doesn't support aliases.
http://reviews.llvm.org/D16501
Files:
lib/CodeGen/CodeGenModule.cpp
t