[PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

2023-06-09 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D16559#4410067 , @garymm wrote: > Could you please add this to the documentation? > Could this be made the default? It seems like nvcc does this by default. Clang already does that, though we only allow variadic functions that don'

[PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

2023-06-09 Thread Gary Miguel via Phabricator via cfe-commits
garymm added a comment. Herald added subscribers: mattd, carlosgalvezp, yaxunl. Herald added a project: All. Could you please add this to the documentation? Could this be made the default? It seems like nvcc does this by default. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

2016-01-26 Thread Chad Rosier via cfe-commits
mcrosier added inline comments. Comment at: cfe/trunk/include/clang/Driver/CC1Options.td:681 @@ -680,1 +680,3 @@ HelpText<"Enable function overloads based on CUDA target attributes.">; +def fcuda_allow_variadic_functions : Flag<["-"], "fcuda-allow-variadic-functions">, + Help

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

2016-01-26 Thread Artem Belevich via cfe-commits
tra added inline comments. Comment at: cfe/trunk/include/clang/Driver/CC1Options.td:681 @@ -680,1 +680,3 @@ HelpText<"Enable function overloads based on CUDA target attributes.">; +def fcuda_allow_variadic_functions : Flag<["-"], "fcuda-allow-variadic-functions">, + HelpText<

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

2016-01-26 Thread Chad Rosier via cfe-commits
mcrosier added inline comments. Comment at: cfe/trunk/include/clang/Driver/CC1Options.td:681 @@ -680,1 +680,3 @@ HelpText<"Enable function overloads based on CUDA target attributes.">; +def fcuda_allow_variadic_functions : Flag<["-"], "fcuda-allow-variadic-functions">, + Help

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

2016-01-26 Thread Chad Rosier via cfe-commits
mcrosier added a subscriber: mcrosier. Comment at: cfe/trunk/include/clang/Driver/CC1Options.td:681 @@ -680,1 +680,3 @@ HelpText<"Enable function overloads based on CUDA target attributes.">; +def fcuda_allow_variadic_functions : Flag<["-"], "fcuda-allow-variadic-functions">,

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

2016-01-26 Thread Justin Lebar via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL258822: [CUDA] Add -fcuda-allow-variadic-functions. (authored by jlebar). Changed prior to commit: http://reviews.llvm.org/D16559?vs=45915&id=46005#toc Repository: rL LLVM http://reviews.llvm.org/D1

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

2016-01-26 Thread Artem Belevich via cfe-commits
tra accepted this revision. tra added a comment. LGTM. http://reviews.llvm.org/D16559 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

2016-01-26 Thread Benjamin Kramer via cfe-commits
bkramer accepted this revision. bkramer added a reviewer: bkramer. bkramer added a comment. This revision is now accepted and ready to land. Looks good to me, but I don't really now CUDA. http://reviews.llvm.org/D16559 ___ cfe-commits mailing list c

[PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

2016-01-25 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: tra. jlebar added subscribers: bkramer, echristo, jhen, cfe-commits. Turns out the variadic function checking added in r258643 was too strict for some existing users; give them an escape valve. When -fcuda-allow-variadic-functions is passed,