This revision was automatically updated to reflect the committed changes.
Closed by commit rL326990: Propagate DLLAttr to friend re-declarations of
member functions (authored by sberg, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D16
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D16632
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sberg updated this revision to Diff 137374.
sberg added a comment.
Turns out DLLAttr-inherited-from-class is only added to members during
Sema::CheckCompletedClass -> Sema::checkClassLevelDLLAttribute, when friend
re-decls of those members may already have been created.
https://reviews.llvm.or
sberg added a comment.
Yeah, my first naive finding when encountering the error was that it went away
when unconditionally using FD->getCanonicalDecl() instead of FD in that
if-else-if block. But that caused other parts of clang-test to fail. The
current version passes all tests (happens to), b
hans added a comment.
Hi Stephan,
I would rather see that we could get this right in the AST.
The problem is that the Befriended::func() definition doesn't have dllexport
attached:
`-CXXMethodDecl 0x5ba1cf0 parent 0x5b4f288 prev 0x5b4f750
col:18 used func 'void (void)'
`-CompoundStmt 0
rnk added a subscriber: rnk.
rnk added a comment.
Hans knows all about dllexport now.
http://reviews.llvm.org/D16632
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sberg created this revision.
sberg added a reviewer: rnk.
sberg added a subscriber: cfe-commits.
...in cases where a member function is redeclared as a friend of a nested
class. (LibreOffice happens to get tripped up by this.)
http://reviews.llvm.org/D16632
Files:
lib/CodeGen/CodeGenModule.c