tra closed this revision.
tra added a comment.
Committed in r259690
http://reviews.llvm.org/D16638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra updated this revision to Diff 46818.
tra added a comment.
Updated comment.
http://reviews.llvm.org/D16638
Files:
lib/Headers/__clang_cuda_runtime_wrapper.h
Index: lib/Headers/__clang_cuda_runtime_wrapper.h
===
---
jlebar added a comment.
lgtm. Thank you.
http://reviews.llvm.org/D16638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar added a comment.
lg with one question about printf.
Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:237
@@ +236,3 @@
+// device-side declaration for it.
+__device__ int printf(const char *, ...);
+} // extern "C"
I think we want an attribute on
tra added inline comments.
Comment at: lib/Headers/__clang_cuda_runtime_wrapper.h:232
@@ +231,3 @@
+// Clang will convert printf into vprintf, but we still need
+// device-side declaration for it.
+__device__ int printf(const char *, ...);
jlebar wrote:
> I'd
tra retitled this revision from "[CUDA] Added device-side std::{malloc/free}"
to "[CUDA] Added device-side system call decls and related wrappers.".
tra updated the summary for this revision.
tra updated this revision to Diff 46803.
tra marked 3 inline comments as done.
tra added a comment.
