Re: [PATCH] D16932: [CUDA] Bug 26497 : Remove wrappers for variants already provided by CUDA headers.

2016-02-05 Thread Justin Lebar via cfe-commits
jlebar accepted this revision. jlebar added a comment. This revision is now accepted and ready to land. Is it worth having a test, if only for one or two functions? http://reviews.llvm.org/D16932 ___ cfe-commits mailing list

Re: [PATCH] D16932: [CUDA] Bug 26497 : Remove wrappers for variants already provided by CUDA headers.

2016-02-05 Thread Artem Belevich via cfe-commits
tra added a comment. I'm not sure what we could test here without CUDA headers. I've tested out-of-tree by compiling thrust unit tests and the test case in PR. http://reviews.llvm.org/D16932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D16932: [CUDA] Bug 26497 : Remove wrappers for variants already provided by CUDA headers.

2016-02-05 Thread Justin Lebar via cfe-commits
jlebar added a comment. Oh right, CUDA headers. We really need to get a buildbot and/or tests in test-suite set up. http://reviews.llvm.org/D16932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D16932: [CUDA] Bug 26497 : Remove wrappers for variants already provided by CUDA headers.

2016-02-05 Thread Artem Belevich via cfe-commits
tra created this revision. tra added reviewers: jingyue, jlebar. tra added a subscriber: cfe-commits. ... and pull them into std namespace with using-declaration instead. http://reviews.llvm.org/D16932 Files: lib/Headers/__clang_cuda_cmath.h Index: lib/Headers/__clang_cuda_cmath.h

Re: [PATCH] D16932: [CUDA] Bug 26497 : Remove wrappers for variants already provided by CUDA headers.

2016-02-05 Thread Artem Belevich via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL259944: [CUDA] Bug 26497 : Remove wrappers for variants provided by CUDA headers. (authored by tra). Changed prior to commit: http://reviews.llvm.org/D16932?vs=47040=47058#toc Repository: rL LLVM