thakis closed this revision.
thakis added a comment.
David landed a better fix in r260388.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D16951/new/
https://reviews.llvm.org/D16951
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D16951
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.
lgtm
http://reviews.llvm.org/D16951
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
thakis added a comment.
Cool, lgtm. Maybe we'll have to downgrade this to a warning eventually since cl
allows it, but for now let's see how this goes.
Comment at: test/SemaCXX/dllimport.cpp:1269
@@ +1268,3 @@
+ virtual ~PR26506_test2() {}
+ constexpr PR26506_test2() {} // ex
majnemer added inline comments.
Comment at: test/SemaCXX/dllimport.cpp:1262
@@ -1261,1 +1261,3 @@
+struct __declspec(dllimport) PR26506_test1 {
+ virtual ~PR26506_test1() {}
thakis wrote:
> cl.exe seems to accept this – do you know how they do that? Do they jus
thakis added a comment.
Thanks for jumping on this so quickly! Hans can probably just stamp this, but I
lack the background, so I must ask:
Comment at: test/SemaCXX/dllimport.cpp:1262
@@ -1261,1 +1261,3 @@
+struct __declspec(dllimport) PR26506_test1 {
+ virtual ~PR26506_test
majnemer created this revision.
majnemer added reviewers: hans, rsmith, thakis, rnk.
majnemer added a subscriber: cfe-commits.
The installation of a class's vptr cannot be performed without code
being executed. This implies that the constructor of a class cannot be
constexpr.
This fixes PR26506.
