akyrtzi added a comment.
Could you check if you can decouple VerifyDiagnosticConsumer from depending on
a particular DiagnosticsEngine ?
http://reviews.llvm.org/D17026
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
akyrtzi added a comment.
I'm not sure removing all the Importer.FromDiag() calls is the right thing. You
are changing
Importer.FromDiag(D->getLocation(), diag::err_unsupported_ast_node)
to
Importer.ToDiag(SourceLocation(), diag::err_unsupported_ast_node)
and you lose the source location infor
esakella added a comment.
In http://reviews.llvm.org/D17026#356418, @akyrtzi wrote:
> Doesn't this mean that _all_ of the Importer.FromDiag() calls will be ignored
> by VerifyDiagnosticConsumer ? Why specifically change only this two and what
> are we going to do with the others ?
> This seems
akyrtzi added a subscriber: akyrtzi.
akyrtzi added a comment.
Doesn't this mean that _all_ of the Importer.FromDiag() calls will be ignored
by VerifyDiagnosticConsumer ? Why specifically change only this two and what
are we going to do with the others ?
This seems more like needing a fix higher
esakella created this revision.
esakella added reviewers: rsmith, klimek, bkramer.
esakella added subscribers: cfe-commits, karies.
Before this change the errors produced by the ASTImporter when trying to import
an unsupported ASTNode where produced through the DiagnosticsEngine of the
FromConte
