jroelofs added a subscriber: jroelofs.
Comment at: test/Modules/ModuleDebugInfo.cpp:10
@@ -9,3 +9,3 @@
// RUN: cat %t-mod.ll | FileCheck %s
// RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s
While you're here, may as well shorten these three lines
jlebar created this revision.
jlebar added a reviewer: majnemer.
jlebar added a subscriber: cfe-commits.
This isn't a FileCheck directive; it does nothing.
http://reviews.llvm.org/D17051
Files:
test/CodeGenCXX/optnone-and-attributes.cpp
test/CodeGenCXX/optnone-class-members.cpp
jroelofs accepted this revision.
jroelofs added a reviewer: jroelofs.
jroelofs added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/Modules/ModuleDebugInfo.cpp:10
@@ -9,3 +9,3 @@
// RUN: cat %t-mod.ll | FileCheck %s
// RUN: cat %t-mod.ll |
jlebar added inline comments.
Comment at: test/Modules/ModuleDebugInfo.cpp:10
@@ -9,3 +9,3 @@
// RUN: cat %t-mod.ll | FileCheck %s
// RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s
jroelofs wrote:
> While you're here, may as well shorten these
jlebar marked 3 inline comments as done.
Comment at: test/Modules/ModuleDebugInfo.cpp:10
@@ -9,3 +9,3 @@
// RUN: cat %t-mod.ll | FileCheck %s
// RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s
jlebar wrote:
> jlebar wrote:
> > jroelofs wrote:
> > >
jlebar marked 2 inline comments as done.
Comment at: test/Modules/ModuleDebugInfo.cpp:10
@@ -9,3 +9,3 @@
// RUN: cat %t-mod.ll | FileCheck %s
// RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s
jroelofs wrote:
> jlebar wrote:
> > jlebar wrote:
> > >
jlebar marked an inline comment as done.
Comment at: test/Modules/ModuleDebugInfo.cpp:10
@@ -9,3 +9,3 @@
// RUN: cat %t-mod.ll | FileCheck %s
// RUN: cat %t-mod.ll | FileCheck --check-prefix=CHECK-NEG %s
jlebar wrote:
> jroelofs wrote:
> > While you're here,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL260334: Get rid of CHECK-SAME-NOT in tests. (authored by
jlebar).
Changed prior to commit:
http://reviews.llvm.org/D17051?vs=47385=47397#toc
Repository:
rL LLVM
http://reviews.llvm.org/D17051